Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symmetric tensor output and action refactor #27529

Merged
merged 7 commits into from
May 9, 2024
Merged

Symmetric tensor output and action refactor #27529

merged 7 commits into from
May 9, 2024

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented May 1, 2024

Closes #27513

@dschwen dschwen force-pushed the symmetric_27513 branch 3 times, most recently from 436427c to 38111c5 Compare May 2, 2024 04:53
@moosebuild
Copy link
Contributor

moosebuild commented May 2, 2024 •
edited
Loading

Job Documentation on eef0e55 wanted to post the following:

View the site here

This comment will be updated on new commits.

@dschwen dschwen force-pushed the symmetric_27513 branch 3 times, most recently from f153f1a to 922d1ba Compare May 6, 2024 17:42
@dschwen dschwen marked this pull request as ready for review May 6, 2024 17:42
@dschwen dschwen requested a review from lindsayad as a code owner May 6, 2024 17:42
@moosebuild
Copy link
Contributor

moosebuild commented May 7, 2024 •
edited
Loading

Job Coverage on eef0e55 wanted to post the following:

Framework coverage

78a82b #27529 eef0e5
Total Total +/- New
Rate 85.11% 85.08% -0.02% 90.13%
Hits 103108 103041 -67 137
Misses 18044 18065 +21 15

Diff coverage report

Full coverage report

Modules coverage

Solid mechanics

78a82b #27529 eef0e5
Total Total +/- New
Rate 84.86% 84.86% - 0.00%
Hits 27671 27671 - 0
Misses 4937 4937 - 1

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • solid_mechanics new line coverage rate 0.00% is less than the suggested 90.0%

This comment will be updated on new commits.

lindsayad
lindsayad requested changes May 8, 2024
View reviewed changes
framework/include/actions/MaterialOutputAction.h Outdated Show resolved Hide resolved
framework/include/actions/MaterialOutputAction.h Outdated Show resolved Hide resolved
framework/include/auxkernels/MaterialAuxBase.h Outdated Show resolved Hide resolved
framework/include/auxkernels/MaterialAuxBase.h Show resolved Hide resolved
framework/include/utils/MooseADWrapper.h Outdated Show resolved Hide resolved
framework/include/utils/ADReal.h Outdated Show resolved Hide resolved
framework/include/utils/MooseTypes.h Outdated Show resolved Hide resolved
framework/include/utils/MooseTypes.h Outdated Show resolved Hide resolved
test/include/materials/OutputTestMaterial.h Show resolved Hide resolved
@dschwen dschwen force-pushed the symmetric_27513 branch 4 times, most recently from 336d986 to 82384f4 Compare May 8, 2024 16:59
@moosebuild
Copy link
Contributor

Job Precheck on 82384f4 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/27529/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 78a82b091e994ca69087b954ef424ea20b2e3053

@dschwen dschwen force-pushed the symmetric_27513 branch 2 times, most recently from c24beae to b2f4b38 Compare May 8, 2024 17:34
lindsayad added a commit to lindsayad/moose that referenced this pull request May 8, 2024
@lindsayad
Simplify AD headers and remove DualReal from the repo
5d2d3ed 
Refs idaholab#27529
@lindsayad lindsayad mentioned this pull request May 8, 2024
Merged
@dschwen dschwen requested a review from lindsayad May 8, 2024 21:41
lindsayad
lindsayad requested changes May 8, 2024
View reviewed changes
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

framework/src/actions/MaterialOutputAction.C Outdated Show resolved Hide resolved
framework/include/actions/MaterialOutputAction.h Outdated Show resolved Hide resolved
lindsayad added a commit to lindsayad/moose that referenced this pull request May 8, 2024
@lindsayad
Simplify AD headers and remove DualReal from the repo
a09bb7d 
Refs idaholab#27529
lindsayad added a commit to lindsayad/moose that referenced this pull request May 8, 2024
@lindsayad
Simplify AD headers and remove DualReal from the repo
8cd08f8 
Refs idaholab#27529
lindsayad added a commit to lindsayad/moose that referenced this pull request May 8, 2024
@lindsayad
Simplify AD headers and remove DualReal from the repo
f86e7b5 
Refs idaholab#27529
lindsayad added a commit to lindsayad/moose that referenced this pull request May 8, 2024
@lindsayad
Simplify AD headers and remove DualReal from the repo
599b758 
Refs idaholab#27529
lindsayad added a commit to lindsayad/moose that referenced this pull request May 8, 2024
@lindsayad
Simplify AD headers and remove DualReal from the repo
0bfc54e 
Refs idaholab#27529
@dschwen
Copy link
Member Author

dschwen commented May 9, 2024

The two fixes for Pronghorn and Isopod are straightforward. I'll prepare PRs for those and will merge this pr once they are up.

@lindsayad
Copy link
Member

I would say check with @loganharbour before merging a breakage. We've gone quite a while without a next -> devel. I don't know whether that would be a pro or a con for merging this. The most recent breakage on Disttributed Mesh is because of me I think ... looking into that now

@dschwen dschwen mentioned this pull request May 9, 2024
Closed
@dschwen
Copy link
Member Author

dschwen commented May 9, 2024 •
edited
Loading

@dschwen dschwen mentioned this pull request May 9, 2024
Merged
@dschwen dschwen merged commit 6393157 into idaholab:next May 9, 2024
44 of 47 checks passed
lindsayad added a commit to lindsayad/moose that referenced this pull request May 9, 2024
@lindsayad
Simplify AD headers and remove DualReal from the repo
abe1513 
Refs idaholab#27529
ke7kto pushed a commit to ke7kto/moose that referenced this pull request May 22, 2024
@lindsayad @ke7kto
Simplify AD headers and remove DualReal from the repo
85770de 
Refs idaholab#27529
pbehne pushed a commit to pbehne/moose that referenced this pull request Jun 12, 2024
@lindsayad @pbehne
Simplify AD headers and remove DualReal from the repo
fd53fac 
Refs idaholab#27529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindsayad lindsayad lindsayad approved these changes

@roystgnr roystgnr Awaiting requested review from roystgnr roystgnr is a code owner

@loganharbour loganharbour Awaiting requested review from loganharbour loganharbour is a code owner

@bwspenc bwspenc Awaiting requested review from bwspenc bwspenc is a code owner

@recuero recuero Awaiting requested review from recuero recuero is a code owner

Assignees

@dschwen dschwen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add output objects/action for SymmetricRank*Tensors
3 participants
@dschwen @moosebuild @lindsayad