Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for thermal scattering not writing out #399

Merged
merged 108 commits into from
Apr 15, 2024
Merged

Bug fix for thermal scattering not writing out #399

merged 108 commits into from
Apr 15, 2024

Conversation

MicahGale
Copy link
Collaborator

New Features

Documentation Updates (#329, #328, #338 )

  • Documented how the new build system works
  • Added DOI to publications section

Bugs fixed

Build improvements (#326, #202)

  • Switched to only using Pyproject.toml
  • Implemented coveralls for coverage
  • Added test report to CI
  • Switching to automatic versioning system for CI/CD
  • Implementing sigstore signing of software and using github releases.

MicahGale and others added 30 commits January 17, 2024 10:24
@MicahGale
Made dev version.
f488d48
@MicahGale
Added MCNP_InputFile to documentation.
a917c40
@MicahGale
Made pass-through option to set encoding.
225fe0e
@MicahGale
Actually propogated option through full stack.
dbf5133
@MicahGale
Actually complete full stack chain(hopefully)
1ffdc81
@MicahGale
Added test for poorly encoded file.
15cfb10
@MicahGale
Actually propogated encoding through.
0dc5656
@MicahGale
Reformmated tests with black.
2e4edb1
@MicahGale
Started simple utility to convert to ascii.
6119f82
@MicahGale
Ignored unicode input file.
eafeb8e
@MicahGale
Made arguments mutually exclusive and corrected defaults.
c837aa1 
-Also changed to binary modes.
@MicahGale
Correctly checked if an argument was there.
c4f8463
@MicahGale
Wrote tests for scripts.
7517d8f
@MicahGale
Updated test to handle going in and out of UTF-8
c92a5d4
@MicahGale
Updated pyproject to expose script, and test it.
1a2b3aa
@MicahGale
Fixed scripts system to actually work.
89a29f1
@MicahGale
Added doc strings.
522820c
@MicahGale
Added utilities and FAQ.
99b8ae4
@MicahGale
Added debugging help for encoding errors.
0746fb1
@MicahGale
Deleted all gitlab CI work.
bac71c7
@MicahGale
Removed pytest.ini
6a14b71
@MicahGale
Moved all requirements to pypyroject.toml
4846286
@MicahGale
Updated actions to not use requirements anymore.
4c33d4a
@MicahGale
Fixed bad maintainers.
bf175fd
@MicahGale
Relaxed black requirement.
0eef2c1
@MicahGale
Had pip defer to local for installing.
d166e43
@MicahGale
Correct setuptools-scm dependency
373cfac
@MicahGale
Ignoring version file from setuptools_scm
88ad4f8
@MicahGale
Implemented Coveralls with a lot of trial and error.
9fb3b12
@MicahGale
Deleted all gitlab CI work.
4f1c6b6
MicahGale and others added 17 commits February 13, 2024 17:37
@MicahGale
Merge branch 'develop' into 363-unsupportedfeature-raised-when-vertic…
e77427a 
…al-input-is-behind-comment
@MicahGale
fix(syntax): Fixed not ignoring vertical mode hidden by comments.
847129e
@MicahGale
Merge branch 'develop' into main
2d5f2cd
@MicahGale
Merge branch 'develop' into 351-lack-of-data-enforcement-in-syntax-no…
9ebc460 
…de-is-showing-up-again
@MicahGale
Removed unused vars.
d7e7de6
@MicahGale
Fixed typo with bug reports labels.
65a463b
@MicahGale
Switched to implicit sys.argv.
0c5f3e2
@MicahGale
Removed unecessary check.
0d7fbe6
@MicahGale
Removed dubplicate TOC entry for input_file.
bfbd0c9
@MicahGale
CI: Implemented better CI and CD
0885472 
Improving CI/CD for Github actions
@MicahGale
Merge branch 'develop' into 351-lack-of-data-enforcement-in-syntax-no…
61b3a23 
…de-is-showing-up-again
@MicahGale
updated coverage options to make coverall paths work.
c57bcfe
@MicahGale
CI(coveralls): fixed path issue with coveralls.
ab21045 
updated coverage options to make coverall paths work.
@MicahGale
Merge branch 'develop' into 351-lack-of-data-enforcement-in-syntax-no…
238176b 
…de-is-showing-up-again
@MicahGale
fix(syntax tree): Fixed typing issue with GeometryTree causing exception
7a24ac0 
Fixed geometry Tree with actual type enforcement
@MicahGale
Updated integration tests to replicate #395.
c675ff1
@MicahGale
Added method to ensure thermal scattering is written to file.
57f8933
@MicahGale MicahGale requested a review from tjlaboss April 12, 2024 15:06
@MicahGale MicahGale self-assigned this Apr 12, 2024
@MicahGale MicahGale added documentation Improvements or additions to documentation bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". CI/CD code improvement A feature request that will improve the software and its maintainability, but be invisible to users. critical An issue that seriously limits user adoption or hampers current use. feature request An issue that improves the user interface. labels Apr 12, 2024
@MicahGale MicahGale marked this pull request as ready for review April 12, 2024 15:07
@MicahGale
Copy link
Collaborator Author

MicahGale commented Apr 12, 2024 •
edited
Loading

This depends on #398

@MicahGale
Fix(material): Fixed thermal scattering law never being written to file.
872662f 
Fix bug with how thermal scattering law data is not written to file: fixes: #395.
@MicahGale MicahGale merged commit d910100 into main Apr 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjlaboss tjlaboss tjlaboss approved these changes

Assignees

@MicahGale MicahGale

Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". CI/CD code improvement A feature request that will improve the software and its maintainability, but be invisible to users. critical An issue that seriously limits user adoption or hampers current use. documentation Improvements or additions to documentation feature request An issue that improves the user interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MicahGale @tjlaboss