Fix bug with hidden vertical input mode. #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SterlingButters would you like to review this one? |
|
@MicahGale I trust you 😎 |
|
Thanks for the confidence @SterlingButters. Though the expectation is that no code gets merged without someone besides the author reviewing it, no matter what. The general things we look for are covered by the merge checklist and the developer philosophy. So would you be willing to complete this required review? If not, no worries we can have someone else review it. |
|
Thanks for the review. |
…al-input-is-behind-comment
MicahGale
deleted the
363-unsupportedfeature-raised-when-vertical-input-is-behind-comment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertical mode detection accidentally wasn't considering comments. This fixed this logic.
Fixes #370.