add central certificate storage (s3/minio) #58
+564
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmalloc
reviewed
Oct 29, 2020
| @@ -44,6 +44,7 @@ func (provider *AdhocProvider) GetExistingCertificate( | |||
| serverName name.ServerName, | |||
| ) (*tls.Certificate, error) { | |||
| cache, _ := provider.cache.Load().(certificateCache) | |||
|
|
|||
There was a problem hiding this comment.
Just FYI if you change a lot of unrelated things like this it makes it really hard to review PRs.
There was a problem hiding this comment.
I was just clearing some linter warnings, housekeeping I added was switching to wrapped errors and removing context.Context from loadCertificate since it wasn't used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is going to grow before it gets out of draft status.
This is a restart of #57 using minio/s3 instead of redis.