Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add central certificate storage #57

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

na4ma4
Copy link
Contributor

@na4ma4 na4ma4 commented Oct 15, 2020

This PR will eventually lead to ACME support, but because multiple replicas of honeycomb can run in a swarm I think there needs to be an ability to centrally store the certificates either ACME or static.

This would also mean that the proxy wouldn't need restarts to add or remove certificates.

This PR is going to grow before it gets out of draft status.

@na4ma4
Copy link
Contributor Author

na4ma4 commented Oct 15, 2020

So far redis has been added, I had some preliminary setup for etcd but redis/memcached could be lighter and easier to deploy next to honeycomb.

There is a cache as well, so if the redis is not available the service can continue to run until it returns.

@na4ma4
Copy link
Contributor Author

na4ma4 commented Oct 15, 2020

I changed PrimaryProvider into a slice so that multiple providers can be used, not sure if that's how you'd want it to work.

@jmalloc
Copy link
Contributor

jmalloc commented Oct 16, 2020

I changed PrimaryProvider into a slice so that multiple providers can be used, not sure if that's how you'd want it to work.

I'd probably implement a new provider that searches through a slice of other providers in order, rather than changing the logic here. Just from a naming perspective it doesn't make sense to have more than one "primary" provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants