Fix brave#1266: Truncate image title when it's too long on long press…

… action.
iccub · Jul 17, 2019 · 84b86dc · 84b86dc
1 parent 4fae8c9
commit 84b86dc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/Client/Frontend/Browser/BrowserViewController.swift b/Client/Frontend/Browser/BrowserViewController.swift
@@ -2523,7 +2523,8 @@ extension BrowserViewController: ContextMenuHelperDelegate {
             let imageText = imageTitle.map { "\n\n\($0)" } ?? ""
             // If the image is a link, show the link's URL. Otherwise, show the image's source URL.
             let urlText = elements.link?.absoluteString ?? url.absoluteString
-            dialogTitle = "\(urlText)\(imageText)"
+            // Truncate text above certain amount of characters
+            dialogTitle = "\(urlText)\(imageText)".truncate(length: 200)
 
             let openInNewTabAction = UIAlertAction(title: Strings.OpenImageInNewTabActionTitle, style: .default) { _ in
                 let isPrivate = PrivateBrowsingManager.shared.isPrivateBrowsing

diff --git a/Shared/Extensions/StringExtensions.swift b/Shared/Extensions/StringExtensions.swift
@@ -109,4 +109,15 @@ extension String {
         addWordsDescriptionBolded.setAttributes(attributes, range: nsRangeOfBoldedText)
         return addWordsDescriptionBolded
     }
+
+    /*
+     Truncates the string to the specified length number of characters and appends an optional trailing string if longer.
+     - Parameter length: Desired maximum lengths of a string
+     - Parameter trailing: A 'String' that will be appended after the truncation.
+
+     - Returns: 'String' object.
+     */
+    public func truncate(length: Int, trailing: String = "…") -> String {
+        return (self.count > length) ? self.prefix(length) + trailing : self
+    }
 }