Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Long press on any image shows image source too long #1266

Closed
GeetaSarvadnya opened this issue Jul 17, 2019 · 3 comments
Closed

Long press on any image shows image source too long #1266

GeetaSarvadnya opened this issue Jul 17, 2019 · 3 comments
Assignees
@iccub
Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.12

Comments

@GeetaSarvadnya
Copy link

Description:

Long press on any image shows image source too long

Steps to Reproduce

  1. clean profile 1.10 (19.07.16.23)
  2. open google.com
  3. search string images
  4. long press on any one image

Actual result:
Long press on any image shows image source too long

IMG_0067

Expected result:

IMG_0069

Reproduces how often: [Easily reproduced, Intermittent Issue]
Always

Brave Version:
1.10 (19.07.16.23)

Device details:
iPhone 8 - iOS 12.3.1

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @brave/legacy_qa @iccub @jhreis
@GeetaSarvadnya GeetaSarvadnya added this to the 1.10 milestone Jul 17, 2019
@iccub iccub self-assigned this Jul 17, 2019
iccub added a commit to iccub/brave-ios that referenced this issue Jul 17, 2019
@iccub
Fix brave#1266: Truncate image title when it's too long on long press…
84b86dc 
… action.
iccub added a commit to iccub/brave-ios that referenced this issue Jul 17, 2019
@iccub
Fix brave#1266: Truncate image title when it's too long on long press…
f9069bf 
… action.
@jhreis jhreis removed this from the 1.10 milestone Jul 17, 2019
@kjozwiak
Copy link
Member

@jhreis would this be removed from the 1.10 release under ZenHub? Looks like it was removed from the 1.10 GH milestone so I'm assuming this isn't making it into 1.10?

@iccub iccub closed this as completed in cfd0f8e Aug 4, 2019
@kylehickinson kylehickinson added this to the 1.12 milestone Aug 4, 2019
This was referenced Sep 5, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Sep 6, 2019 •
edited by kjozwiak
Loading

Verification passed on iPhone XR with iOS 13.1 beta 2 running 1.12(19.09.06.17)

  • Verified data source is shown on both normal and private tab
    image

Verification PASSED on iPad Air 3rd Generation with iOS 13.1 running 1.12 (19.09.07.03):

  • ensured that the data source was displayed for both normal and private tabs

IMG_F5C599866768-1

@srirambv srirambv mentioned this issue Sep 13, 2019
Closed
@srirambv
Copy link
Contributor

srirambv commented Sep 13, 2019 •
edited
Loading

Verification failed on iPhone 7+ with iOS 12.4.1 running 1.12(19.09.13.06).

Based on internal discussion this is working as expected on iPhone 7+ with iOS 12.4.1 running 1.12(19.09.1306)

Logged #1547

@srirambv srirambv mentioned this issue Oct 3, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
6 participants
@kylehickinson @kjozwiak @jhreis @iccub @srirambv @GeetaSarvadnya