Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RRULE Evaluation: Apply BYYEARDAY=366 only in leap years. #621

Merged
merged 1 commit into from
Oct 24, 2024
Merged

RRULE Evaluation: Apply BYYEARDAY=366 only in leap years. #621

merged 1 commit into from
Oct 24, 2024

Conversation

minichma
Copy link
Collaborator

Fix for the following cases of #618:

  • RRULE:FREQ=YEARLY;BYYEARDAY=-366;COUNT=3
  • RRULE:FREQ=YEARLY;BYYEARDAY=366;COUNT=3

I.e. BYYEARDAY=366 should only exist if day 366 (or -366) exists, which is only the case in leap years.

@minichma minichma marked this pull request as ready for review October 20, 2024 22:07
@minichma minichma requested a review from axunonb October 22, 2024 13:52
axunonb
axunonb previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@axunonb axunonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks

@minichma minichma force-pushed the bugfix/rrule_byday_366 branch from 8f70269 to c4f1888 Compare October 24, 2024 08:53
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@minichma
Copy link
Collaborator Author

minichma commented Oct 24, 2024 •
edited
Loading

@axunonb I think you need to approve again. Thanks!

axunonb
axunonb approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@axunonb axunonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved, thanks

@minichma minichma merged commit 2146ea0 into ical-org:main Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axunonb axunonb axunonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minichma @axunonb