Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate some tests failing from the libical test suite. #618

Open
5 of 8 tasks
minichma opened this issue Oct 20, 2024 · 1 comment
Open
5 of 8 tasks

Evaluate some tests failing from the libical test suite. #618

minichma opened this issue Oct 20, 2024 · 1 comment

Comments

@minichma
Copy link
Collaborator

minichma commented Oct 20, 2024

When running a list of test cases from the libical project, the following tests fail. The reason should be investigated.

  • DTSTART:20120101T120000, RRULE:FREQ=YEARLY;BYYEARDAY=-366;COUNT=3
    Values differ at index [1]
    Expected: <01.01.2016 12:00:00 UTC>
    But was: <31.12.2012 12:00:00 UTC>

  • DTSTART:20121231T120000, RRULE:FREQ=YEARLY;BYYEARDAY=366;COUNT=3
    Values differ at index [1]
    Expected: <31.12.2016 12:00:00 UTC>
    But was: <01.01.2014 12:00:00 UTC>

  • DTSTART:20121231T120000, RRULE:FREQ=YEARLY;BYYEARDAY=366;UNTIL=20200101T000000
    Values differ at index [1]
    Expected: <31.12.2016 12:00:00 UTC>
    But was: <01.01.2014 12:00:00 UTC>

  • DTSTART:20130101T000000, RRULE:FREQ=YEARLY;BYWEEKNO=1,2,-1,-2;BYDAY=TU;UNTIL=20170101T000000Z
    System.ArgumentOutOfRangeException : The added or subtracted value results in an un-representable DateTime. (Parameter 'value')
    DateTime.ThrowDateArithmetic(Int32 param)
    DateTime.AddTicks(Int64 value)
    RecurrencePatternEvaluator.GetWeekNoVariants(List1 dates, RecurrencePattern pattern, Nullable1 expand) line 425

  • DTSTART:20141006T090000, RRULE:FREQ=WEEKLY;INTERVAL=1;COUNT=2;BYDAY=MO;
    Fixed in Fix some recurrence evaluation issues #645
    System.IndexOutOfRangeException : Index was outside the bounds of the array.
    RecurrencePatternSerializer.Deserialize(TextReader tr) line 244

  • DTSTART:20161229T090000, RRULE:FREQ=WEEKLY;UNTIL=20170127T000000Z;WKST=MO;BYDAY=SU,TU,TH;INTERVAL=2
    Fixed in Fix some recurrence evaluation issues #645
    Expected is <System.Collections.Generic.List1[Ical.Net.DataTypes.CalDateTime]> with 6 elements, actual is <System.Collections.Generic.List1[Ical.Net.DataTypes.IDateTime]> with 7 elements
    Values differ at index [1]
    Expected: <10.01.2017 09:00:00 UTC>
    But was: <03.01.2017 09:00:00 UTC>

  • DTSTART:20180206T080001, RRULE:FREQ=YEARLY;BYWEEKNO=6;BYDAY=TU;WKST=TH;UNTIL=20210612T000000Z
    Expected is <System.Collections.Generic.List1[Ical.Net.DataTypes.CalDateTime]> with 4 elements, actual is <System.Collections.Generic.List1[Ical.Net.DataTypes.IDateTime]> with 3 elements
    Values differ at index [0]
    Expected: <13.02.2018 08:00:01 UTC>
    But was: <06.02.2018 08:00:01 UTC>

  • DTSTART:20241018, RRULE:FREQ=DAILY;BYMINUTE=1,2,3,4;INTERVAL=2;COUNT=3
    Fixed by RRULE evaluation: Ignore BYtime if DTSTART is date-only #619
    Expected is <System.Collections.Generic.List1[Ical.Net.DataTypes.CalDateTime]> with 3 elements, actual is <System.Collections.Generic.List1[Ical.Net.DataTypes.IDateTime]> with 3 elements
    Values differ at index [0]
    Expected: <18.10.2024 UTC>
    But was: <18.10.2024 00:01:00 UTC>

Also see #617

@axunonb
Copy link
Collaborator

axunonb commented Oct 20, 2024

This is a brilliant source to improve the code (and a brilliant idea, of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants