Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring distinct compilers for OpenJ9 #147

Merged
merged 3 commits into from
Nov 2, 2018

Conversation

keithc-ca
Copy link
Member

  • --with-openj9-cc : select C compiler
  • --with-openj9-cxx : select C++ compiler
  • --with-openj9-developer-dir : select Xcode version (MacOS)

This replaces the use of environment variables in #144.

Copy link
Member

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@keithc-ca keithc-ca requested a review from DanHeidinga October 22, 2018 13:42
Copy link
Contributor

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (jdk11 version of this has already been built and merged)

@DanHeidinga
Copy link
Contributor

Jenkins compile xlinux,win jdk8

@DanHeidinga
Copy link
Contributor

Jenkins test sanity zlinux jdk8

@DanHeidinga
Copy link
Contributor

Jenkins copyright check

@DanHeidinga DanHeidinga self-assigned this Oct 31, 2018
* remove unnecessary use of double-quotes
* use whitespace consistently
* punctuation

Signed-off-by: Keith W. Campbell <[email protected]>
* `--with-openj9-cc`  : select C compiler
* `--with-openj9-cxx` : select C++ compiler
* `--with-openj9-developer-dir` : select Xcode version (MacOS)

Signed-off-by: Keith W. Campbell <[email protected]>
Signed-off-by: Keith W. Campbell <[email protected]>
@keithc-ca
Copy link
Member Author

Resolved merge conflicts and rebased.

@DanHeidinga
Copy link
Contributor

Jenkins compile xlinux,win jdk8

@DanHeidinga
Copy link
Contributor

18:53:36 The following files were modified and have incorrect copyrights
[Pipeline] echo
18:53:36 common/autoconf/generated-configure.sh

The copyright check is failing in the generated configure file which is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants