-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring distinct compilers for OpenJ9 #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (jdk11 version of this has already been built and merged)
Jenkins compile xlinux,win jdk8 |
Jenkins test sanity zlinux jdk8 |
Jenkins copyright check |
* remove unnecessary use of double-quotes * use whitespace consistently * punctuation Signed-off-by: Keith W. Campbell <[email protected]>
* `--with-openj9-cc` : select C compiler * `--with-openj9-cxx` : select C++ compiler * `--with-openj9-developer-dir` : select Xcode version (MacOS) Signed-off-by: Keith W. Campbell <[email protected]>
Signed-off-by: Keith W. Campbell <[email protected]>
Resolved merge conflicts and rebased. |
Jenkins compile xlinux,win jdk8 |
The copyright check is failing in the generated configure file which is OK. |
--with-openj9-cc
: select C compiler--with-openj9-cxx
: select C++ compiler--with-openj9-developer-dir
: select Xcode version (MacOS)This replaces the use of environment variables in #144.