Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring distinct compilers for OpenJ9 #42

Merged
merged 2 commits into from
Oct 31, 2018

Conversation

keithc-ca
Copy link
Member

  • --with-openj9-cc : select C compiler
  • --with-openj9-cxx : select C++ compiler
  • --with-openj9-developer-dir : select Xcode version (MacOS)

This is a replay of ibmruntimes/openj9-openjdk-jdk8#147.

* remove unnecessary use of double-quotes
* use whitespace consistently
* punctuation

Signed-off-by: Keith W. Campbell <[email protected]>
* `--with-openj9-cc`  : select C compiler
* `--with-openj9-cxx` : select C++ compiler
* `--with-openj9-developer-dir` : select Xcode version (MacOS)

Signed-off-by: Keith W. Campbell <[email protected]>
Copy link
Member

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@keithc-ca keithc-ca requested a review from DanHeidinga October 22, 2018 13:42
Copy link
Contributor

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - same change already merged in jdk11 stream

@DanHeidinga
Copy link
Contributor

Merging as is as we don't have PR builds on this repo yet

@DanHeidinga DanHeidinga merged commit 1a8d5bb into ibmruntimes:openj9-jdk Oct 31, 2018
@keithc-ca keithc-ca deleted the compilers branch October 31, 2018 07:11
dnakamura pushed a commit to dnakamura/openj9-openjdk-jdk that referenced this pull request Aug 30, 2021
Support including healthcenter agent module
tajila pushed a commit to tajila/openj9-openjdk-jdk that referenced this pull request Oct 23, 2023
Modify get_source.sh to automatically fetch release branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants