[patch] Add unlimited retries and fix suite cert/dns sync & run olm job at same time as dns. #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #184 from ibm-mas/dev
[patch] main -> dev
* [minor] Set retry unlimited on cluster + instance * Set retry to unlimited * Run olm job at same time as dns
whitfiea
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
retry.limitfor the ArgoCD instance and cluster appsets, and sets it to unlimited (-1). This means that argocd will continue to sync until it is ready and won't fail when the default (5) failures are reached. This is needed as we see many temporal failures in each app that is just a failure until another app is ready.This change also changes the syncwave of the suite certs and dns jobs so it runs at the same time as the olm job, as these jobs can take 15 minutes, and was blocking the olm job from running when it could have run at the same time.
Tested in fvtsaas and it all works
https://jsw.ibm.com/browse/MASCORE-3889