[patch] Fix syncwaves in app route label job #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitfiea
changed the title
tomklapiscak
approved these changes
Aug 22, 2024
tomklapiscak
added a commit
that referenced
this pull request
Aug 29, 2024
Merge pull request #184 from ibm-mas/dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syncwaves in the app route label job were incorrect causing the job to run before the workspace was installed. The job waits for the ready workspace so it ends in deadlock.
Updated the syncwaves to align with the others in the chart, but the main change is to the job itself being after the workspace cr