Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ibisNA #9344

Merged
merged 5 commits into from
Jun 11, 2024
Merged

refactor: remove ibisNA #9344

merged 5 commits into from
Jun 11, 2024

Conversation

ncclementi
Copy link
Contributor

This PR removes ibis.NA, replacing it appearances for ibis.null()

Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@ncclementi ncclementi changed the title refactor: Remove ibisNA refactor: remove ibisNA Jun 10, 2024
@ncclementi ncclementi requested a review from jcrist June 10, 2024 17:55
@ncclementi ncclementi added this to the 9.1 milestone Jun 10, 2024
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise LGTM!

ibis/tests/test_api.py Outdated Show resolved Hide resolved
Co-authored-by: Jim Crist-Harif <[email protected]>
@ncclementi ncclementi merged commit 83db19d into ibis-project:main Jun 11, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove ibis.NA
2 participants