-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove ibis NA #9323
refactor: remove ibis NA #9323
Conversation
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
I accidentally change the html from a doc freeze, that had a |
Copying a question from the issue into the PR:
I think most users never touch Two ways I can see to do a cleaner deprecation:
I think the former is a better deprecation method, but either would work well enough. |
@@ -125,3 +128,18 @@ def connect(*args, **kwargs): | |||
setattr(proxy, name, getattr(backend, name)) | |||
|
|||
return proxy | |||
|
|||
|
|||
def __getattr__(name: str) -> Any: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we already had a __getattr__
I went this route to keep the typing for the load_backend
portion. Once we deprecate NA completely we can remove the workaround
I'll rebase here once we merged #9300 |
import ibis | ||
|
||
return ibis.null() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should work instead, since null
is already imported above:
import ibis | |
return ibis.null() | |
return null() |
"Accessing 'ibis.NA' is deprecated as of v9.1 and will be removed in a future version. " | ||
"Use 'ibis.null()' instead.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Accessing 'ibis.NA' is deprecated as of v9.1 and will be removed in a future version. " | |
"Use 'ibis.null()' instead.", | |
"The 'ibis.NA' constant is deprecated as of v9.1 and will be removed in a future " | |
"version. Use 'ibis.null()' instead.", |
The amount of conflicts got a bit nasty, it'll be faster to open a new PR and make it cleaner. I'll put this up in a few min. |
Closing in favor of #9344 |
This PR removes
ibis.NA
, replacing it appearances foribis.null()
Merge after #9300 - I'll rebase based on main once merged