Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trino): remove invalid ranking function window frames #10363

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Oct 24, 2024

Fixes the failing trino tests.

@cpcloud cpcloud added this to the 10.0 milestone Oct 24, 2024
@cpcloud cpcloud added the trino The Trino backend label Oct 24, 2024
@cpcloud cpcloud force-pushed the renovate/trinodb-trino-463.x branch from 33e1d98 to e5c1d4c Compare October 24, 2024 12:26
@cpcloud cpcloud added the bug Incorrect behavior inside of ibis label Oct 24, 2024
@github-actions github-actions bot added tests Issues or PRs related to tests sql Backends that generate SQL labels Oct 24, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Oct 24, 2024

Both Trino jobs passed, merging!

@cpcloud cpcloud merged commit 348500c into ibis-project:main Oct 24, 2024
78 checks passed
@cpcloud cpcloud deleted the renovate/trinodb-trino-463.x branch October 24, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis sql Backends that generate SQL tests Issues or PRs related to tests trino The Trino backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant