fix(trino): remove invalid ranking function window frames (#10363)

ibis-project · Oct 24, 2024 · 348500c · 348500c
1 parent 288d248
commit 348500c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/ibis/backends/sql/compilers/trino.py b/ibis/backends/sql/compilers/trino.py
@@ -23,6 +23,8 @@
 from ibis.backends.sql.dialects import Trino
 from ibis.backends.sql.rewrites import (
     exclude_unsupported_window_frame_from_ops,
+    exclude_unsupported_window_frame_from_rank,
+    exclude_unsupported_window_frame_from_row_number,
     lower_sample,
     split_select_distinct_with_order_by,
 )
@@ -38,6 +40,8 @@ class TrinoCompiler(SQLGlotCompiler):
     agg = AggGen(supports_filter=True, supports_order_by=True)
 
     rewrites = (
+        exclude_unsupported_window_frame_from_row_number,
+        exclude_unsupported_window_frame_from_rank,
         exclude_unsupported_window_frame_from_ops,
         *SQLGlotCompiler.rewrites,
     )

diff --git a/ibis/backends/tests/snapshots/test_sql/test_rewrite_context/trino/out.sql b/ibis/backends/tests/snapshots/test_sql/test_rewrite_context/trino/out.sql
@@ -1,4 +1,4 @@
 SELECT
-  NTILE(2) OVER (ORDER BY RAND() ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) - 1 AS "new_col"
+  NTILE(2) OVER (ORDER BY RAND() ASC) - 1 AS "new_col"
 FROM "test" AS "t0"
 LIMIT 10