Skip to content

Commit

Permalink
revert: fix(deps): update dependency sqlglot to v21 (#8278)
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud authored Feb 8, 2024
1 parent efaa365 commit 9427afc
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion ibis/backends/snowflake/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1004,7 +1004,7 @@ def insert(
query = sg.exp.insert(
expression=self.compile(obj),
into=table,
columns=[sg.column(col, quoted=True) for col in obj.columns],
columns=[sg.to_identifier(col, quoted=True) for col in obj.columns],
dialect=self.name,
)
with self.begin() as con:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ WITH t0 AS (
t1.field_of_study AS field_of_study,
t1.years AS years,
t1.degrees AS degrees,
ARBITRARY(t1.degrees) OVER (PARTITION BY t1.field_of_study ORDER BY t1.years ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS earliest_degrees,
ARBITRARY(t1.degrees) OVER (PARTITION BY t1.field_of_study ORDER BY t1.years ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS latest_degrees
FIRST_VALUE(t1.degrees) OVER (PARTITION BY t1.field_of_study ORDER BY t1.years ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS earliest_degrees,
LAST_VALUE(t1.degrees) OVER (PARTITION BY t1.field_of_study ORDER BY t1.years ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS latest_degrees
FROM t1
), t3 AS (
SELECT
Expand Down
10 changes: 5 additions & 5 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pyarrow-hotfix = ">=0.4,<1"
python-dateutil = ">=2.8.2,<3"
pytz = ">=2022.7"
rich = ">=12.4.4,<14"
sqlglot = ">=18.12.0,<=21.0.1"
sqlglot = ">=18.12.0,<=20.11"
toolz = ">=0.11,<1"
typing-extensions = ">=4.3.0,<5"
black = { version = ">=22.1.0,<25", optional = true }
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ sqlalchemy-exasol==4.6.3 ; python_version >= "3.9" and python_version < "4.0"
sqlalchemy-risingwave==1.0.0 ; python_version >= "3.9" and python_version < "4.0"
sqlalchemy-views==0.3.2 ; python_version >= "3.9" and python_version < "4.0"
sqlalchemy==1.4.51 ; python_version >= "3.9" and python_version < "4.0"
sqlglot==21.0.1 ; python_version >= "3.9" and python_version < "4.0"
sqlglot==20.8.0 ; python_version >= "3.9" and python_version < "4.0"
stack-data==0.6.3 ; python_version >= "3.9" and python_version < "4.0"
statsmodels==0.14.1 ; python_version >= "3.10" and python_version < "3.13"
stdlib-list==0.10.0 ; python_version >= "3.9" and python_version < "4.0"
Expand Down

2 comments on commit 9427afc

@chelsea-lin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might I ask any reasons to revert this change? I am thinking if we can include the latest version of sqlglot, so that it can include fixes for tobymao/sqlglot#2941
These fixes can help to add offset for the unnest function.

@cpcloud
Copy link
Member Author

@cpcloud cpcloud commented on 9427afc Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I listed the reasons in the PR here:

#8278

Please sign in to comment.