Support @mui/material package naming #423
Conversation
|
cc: @joemaffei (thanks for the prior changes!) |
|
Looking forward to it. Good work 👍 |
|
Thank you, was just looking for when notistack would be compatible with the MUI 5 RC 🙏 |
|
Looks like a nice effort, but you shouldn't import from |
|
hey @hugofpsilva, my understanding is that while
I think some additional work will be needed to migrate notistack from JSS to emotion. This PR just aims to update the imports to work with the latest RC. |
package.json
Outdated
| "@emotion/react": "^11.4.1", | ||
| "@emotion/styled": "^11.3.0", | ||
| "@material-ui/core": "^5.0.0-beta.4" | ||
| "@mui/material": "^5.0.0-rc.0", | ||
| "@mui/styles": "^5.0.0-rc.0", |
There was a problem hiding this comment.
This branch is no longer dependant on @mui/styles afaik.
You added it here where it was no longer present.
|
looks like things do work without |
|
From the migration guide:
JSS's |
|
Hey @ramosbugs @hugofpsilva thanks for the work on this! Any updates on when to expect a merge/release? We are waiting on this to upgrade to the MUI 5 RC. Cheers |
|
Thanks @ramosbugs and @hugofpsilva for your contribution. I'll have a look and publish a new release with these changes during the weekend, if not before. |
|
Looking forward to this publish to unlock our upgrade to 5 process 🙂 |
|
@iamhosseindhv wondering if you have a code sandbox ci so we could use this PRs content through the ci build. Like they did here: mui/mui-x#2527 (comment) |
iamhosseindhv
changed the title
|
This is published as |
Could you publish it as 1.1.x, othervise ^1.0.6-next.3 updates to 1.0.10, and breaks( |
* Closes #334 #333 - Fix collapse keys * 1.0.3-alpha.0 * 1.0.4-alpha.0 * 1.0.6-alpha.0 * Fixes #355 - Update MUI peer dependency to next * 1.0.6-next.0 * Use root classKey for Collapse * 1.0.6-next.1 * Add support for Material-UI v5 beta (#418) * upgrade to material-ui v5; modify code as recommended by the material-ui docs * upgrade to material-ui v5; modify code as recommended by the material-ui docs * add missing anchor classes to SnackbarItem; fix child class declarations * update dependencies; run build * package-lock update * Allow passing classes from props * Adapt new MUI breakpoints * Bind this * Mark emotion peerDeps as optional * 1.0.6-next.2 Co-authored-by: Hossein Dehnokhalaji <[email protected]> * Support @mui/material package naming (#423) * Support Material-UI 5.0.0-rc.0 * Bump version to 1.0.6-next.3 * Remove @mui/styles dependency * Prepare next to be published as latest (#436) * Add tag for people on mui-v4 * Update simple example * Update simple example * Update redux example * Update mobx example * Minor * Update next --> latest in example codes * Update docs * Update CHANGELOG * Update MUI v5 peerDependencies * Update version to v2.0.2 * Update docs.json Co-authored-by: Joe Maffei <[email protected]> Co-authored-by: David Ramos <[email protected]>
|
@MonstraG Since mui v5 is published as stable release, you can now download notistack using |
The new Material UI 5.0 release candidate (
5.0.0-rc.0) includes some package renaming from@material-ui/*to@mui/*. This PR performs that migration so thatnotistack 1.0.6-next.3will work with the release candidate and its successors.I've tested this change locally using
npm packand importing that tarball into my project, and the imports seem to resolve properly.This change also inadvertently upgraded the package-lock.json file to NPM v7's format (due to my local dev environment), but that change is backward compatible to NPM 6.