Add support for Material-UI v5 beta #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@iamhosseindhv is there any chance this can merged the upcoming days? |
iamhosseindhv
changed the title
|
Thanks for your contribution. I'm reviewing this PR. |
This comment has been minimized.
This comment has been minimized.
|
@iamhosseindhv Seems to work fine with material-ui v5 (i.e. ts and js versions) when the |
onpaws
added a commit
to splitgraph/splitgraph.com
that referenced
this pull request
Aug 19, 2021
- intended to support the notistack alpha release that claims MUIv5 beta support - at the time of writing, latest MUI release is 5.0.0-beta.4 - if CI doesn't pass, another option is here: iamhosseindhv/notistack#418
|
@iamhosseindhv conflicts resolved |
iamhosseindhv
changed the title
|
Thanks for your contribution all specially @joemaffei @onpaws ❤️. You can now use this by |
iamhosseindhv
added a commit
that referenced
this pull request
Sep 26, 2021
* Closes #334 #333 - Fix collapse keys * 1.0.3-alpha.0 * 1.0.4-alpha.0 * 1.0.6-alpha.0 * Fixes #355 - Update MUI peer dependency to next * 1.0.6-next.0 * Use root classKey for Collapse * 1.0.6-next.1 * Add support for Material-UI v5 beta (#418) * upgrade to material-ui v5; modify code as recommended by the material-ui docs * upgrade to material-ui v5; modify code as recommended by the material-ui docs * add missing anchor classes to SnackbarItem; fix child class declarations * update dependencies; run build * package-lock update * Allow passing classes from props * Adapt new MUI breakpoints * Bind this * Mark emotion peerDeps as optional * 1.0.6-next.2 Co-authored-by: Hossein Dehnokhalaji <[email protected]> * Support @mui/material package naming (#423) * Support Material-UI 5.0.0-rc.0 * Bump version to 1.0.6-next.3 * Remove @mui/styles dependency * Prepare next to be published as latest (#436) * Add tag for people on mui-v4 * Update simple example * Update simple example * Update redux example * Update mobx example * Minor * Update next --> latest in example codes * Update docs * Update CHANGELOG * Update MUI v5 peerDependencies * Update version to v2.0.2 * Update docs.json Co-authored-by: Joe Maffei <[email protected]> Co-authored-by: David Ramos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the existing styling using the conventions recommended by the Material-UI team for upgrading to v5.
Fixes #412