Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: make MockFunction generic #267

Merged
merged 2 commits into from
Nov 7, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/esmock.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,19 @@ type MockFunction = {
* @param opts
* @returns The mocked import-tree result of "import({@link modulePath})"
*/
(
<T>(
Copy link
Collaborator

@koshic koshic Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<T = any>, to keep 'any' type by default. Without '= any', esmock(...) result will be Promise<unknown>

modulePath: string,
parent: string,
defs?: MockMap,
gdefs?: MockMap,
opts?: Options
): any,
(
): Promise<T>,
<T>(
modulePath: string,
defs?: MockMap,
gdefs?: MockMap,
opts?: Options
): any
): Promise<T>
}

/**
Expand Down