typings: make MockFunction generic #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows esmock to be used in a more convenient way in typescript setups
```
import esmock from 'esmock';
import type * as moduleUnderTest from './moduleUnderTest.js';
const { func } = await esmock<typeof moduleUnderTest>(
'./moduleUnderTest.js',
import.meta.url,
{
//...
},
);
const actual = await func();
```
|
Btw thank you so much for creating this module @bumblehead! :) |
ahmed-hritani
approved these changes
Nov 7, 2023
koshic
requested changes
Nov 7, 2023
src/esmock.d.ts
Outdated
| @@ -22,19 +22,19 @@ type MockFunction = { | |||
| * @param opts | |||
| * @returns The mocked import-tree result of "import({@link modulePath})" | |||
| */ | |||
| ( | |||
| <T>( | |||
There was a problem hiding this comment.
<T = any>, to keep 'any' type by default. Without '= any', esmock(...) result will be Promise<unknown>
koshic
approved these changes
Nov 7, 2023
|
@uwinkelvos thanks for the thanks --that makes me glad to read that. Its fine for me if @koshic publishes, but I'm going to publish now since it is not published. one moment... |
|
@iambumblehead just want you do decide - it's not an emergency case, so ) |
|
changes are published to v2.6.0 https://github.com/iambumblehead/esmock/releases/tag/v2.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows esmock to be used in a more convenient way in typescript setups