Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xwayland/xwayland_shell: move to hyprland impl #6086

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

vaxerski
Copy link
Member

@vaxerski vaxerski commented May 15, 2024

Moving wlr_xwayland to a hyprland impl.

TODO:

  • c+p
    • support outgoing
    • support INCR
    • support incoming
  • dnd
  • Support no_xwayland builds
  • set xwayland cursor
  • Meson
  • Nix
  • Wiki
  • Testing

Bugs:

  • Some apps can't copy/paste because of mime mismatches

@khaneliman
Copy link

Ah.. so xwayland is still in progress.. i was gonna make a issue for misc things i've seen that seem to be xwayland related. I'll avoid making noise for stuff that's actively being developed.

@vaxerski
Copy link
Member Author

ye this will move the xwl impl to hl from wlr

@vaxerski vaxerski force-pushed the xwayland-rewrite branch 2 times, most recently from e399d9c to 047f0e4 Compare May 15, 2024 18:23
@vaxerski vaxerski force-pushed the xwayland-rewrite branch 3 times, most recently from 1dd82ca to df625e0 Compare May 16, 2024 17:44
@iddm
Copy link
Contributor

iddm commented May 17, 2024

Perhaps, this is not the best place to suggest what I want. I want to suggest the support of the primary monitor. Some apps, full-screen apps, or multi-monitor apps allow one of the monitors to be set as a primary. Some of the apps are broken, those windows are not rendered at all, and the mouse coordinates are not propagated properly. All until I perform xrandr --output DP-2 --primary for my monitor. I'd personally avoid constantly opening a terminal and writing this invocation there, in favour of something in the configuration:

monitor=DP-2, preferred, auto, 1, vrr, 0, bitdepth, 10, primary

@vaxerski
Copy link
Member Author

use a plugin then, there is one specifically for that

@vaxerski vaxerski force-pushed the xwayland-rewrite branch 3 times, most recently from e19b162 to b5398fb Compare May 17, 2024 14:37
@vaxerski vaxerski force-pushed the xwayland-rewrite branch 4 times, most recently from e9296cc to c38f94e Compare May 17, 2024 17:53
@vaxerski vaxerski marked this pull request as ready for review May 17, 2024 17:54
@vaxerski
Copy link
Member Author

vaxerski commented May 17, 2024

This is generally ready for testing, INCR doesn't matter that much for now, and dnd can be added at a later date (if ever, it's not crucial)

Better to have it work 99% of the times rather than not at all.

@vaxerski vaxerski force-pushed the xwayland-rewrite branch 2 times, most recently from fe05f06 to 8a2985e Compare May 17, 2024 18:58
@Agent00Ming
Copy link
Contributor

Window focus seems to be out of order for xwayland windows across workspaces on the same monitor. I can interact with a window on a workspace other than the active one and switching between workspaces doesn't guarantee the ability to interact with the xwayland window on the active workspace.

@vaxerski
Copy link
Member Author

I assume there is no reliable repro?

@alba4k
Copy link
Contributor

alba4k commented May 17, 2024

I'll test in a couple of hours if you want

@Agent00Ming
Copy link
Contributor

Agent00Ming commented May 17, 2024

if a picture is worth a thousand words I'm sure a video must be worth at least a thousand more

xwayland_funny.mp4

@vaxerski
Copy link
Member Author

great that I can't repro

On a side note: I hate this.

@Agent00Ming
Copy link
Contributor

I'm having trouble finding xwayland apps to test but the common denominator seems to be steam when it comes to the focus bug.

@Agent00Ming
Copy link
Contributor

Agent00Ming commented May 17, 2024

hyprlandCrashReport55314.txt

hyprland crash when closing out of krita and also opening it (?)

hyprlandCrashReport56235.txt

@vaxerski
Copy link
Member Author

no they fuckin dont

@Agent00Ming
Copy link
Contributor

Agent00Ming commented May 25, 2024

they don't in nested but do in DRM for me nvm, also happens in nested with default config too.

parent window has to be xwayland and floating, you have to click the popup on a spot where it won't be dismissed immediately (like expanding popups)

image

^ repro'd in a nested session with QT_QPA_PLATFORM=xcb kate

@vaxerski
Copy link
Member Author

vaxerski commented May 25, 2024

fixed and fuck you

anything else?

@Agent00Ming

This comment was marked as off-topic.

@vaxerski
Copy link
Member Author

too bad this is a tiling wm for a reason

(though wtf are you sure this isnt the case on main?)

@Agent00Ming
Copy link
Contributor

nvm, that specific one is also weird on main

@Agent00Ming
Copy link
Contributor

Agent00Ming commented May 25, 2024

yeah, current state is looking mighty fine. I'll go over one last pass of everything and it's probably all good.

image

@vaxerski
Copy link
Member Author

and then onto the last one from wayland stuff, wl_compositor, wl_subcompositor, wl_buffer, etc...

@Agent00Ming
Copy link
Contributor

  • steam ✔️
  • games (proton & native, xwl) ✔️
  • QT_QPA_PLATFORM=xcb ✔️
  • GDK_BACKEND=x11 (inkscape works now? lol) ✔️
  • copy-paste across wayland and xwayland (firefox still funny on xwl) ✔️
  • windowrule class & title ✔️
  • tablet input ✔️ (except rnote pressure, probably not designed with x11 in mind)
  • osu-lazer ✔️ ✔️ ✔️

@vaxerski
Copy link
Member Author

dope, lets get this bread then gamers

@vaxerski vaxerski merged commit addd3e7 into main May 25, 2024
19 checks passed
@vaxerski
Copy link
Member Author

I'll start the work on the last MR tomorrow, though I have only a laptop and limited time atm, dunno how long it will take :P

@nonetrix
Copy link

Still not working at all for me unfortunately like I previously showed

@Agent00Ming
Copy link
Contributor

Still not working at all for me unfortunately like I previously showed

#6086 (comment)
nix shenanigans? seems like your DISPLAY env isn't set correctly

@fufexan
Copy link
Member

fufexan commented May 25, 2024

Still not working at all for me unfortunately like I previously showed

#6086 (comment) nix shenanigans? seems like your DISPLAY env isn't set correctly

Can't be nix, steam works fine for me.

@VirtCode
Copy link
Contributor

the titles in IntelliJ were also kinda forgotten

@vaxerski
Copy link
Member Author

the titles in IntelliJ were also kinda forgotten

get rekt (tbh is it that important)

@VirtCode
Copy link
Contributor

haha not really, i don't even use them

but some people might have the window title in their bar, or want to apply window rules for specific projects

@vaxerski
Copy link
Member Author

they can open an issue and I'll probably look into it after the last wayland-related MR when I start the 1-2 weeks of cleanups

@vaxerski
Copy link
Member Author

sorry tester fam, no way I'll get even a draft done by today, it's already 10:30 and I still have tons of shit before it even compiles.

I hate writing code on a laptop

@vaxerski
Copy link
Member Author

for those interested, a very wip draft #6268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipboard synchronization between wayland and xwayland clients broken