Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable inline styles in the site's CSP policy #4445

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

robertknight
Copy link
Member

Blocking inline styles prevents the client's adder toolbar from working
properly on /docs/help and other pages on the site until
hypothesis/client#293 is resolved.

Blocking inline styles prevents the client's adder toolbar from working
properly on /docs/help and other pages on the site until
hypothesis/client#293 is resolved.
@codecov-io
Copy link

Codecov Report

Merging #4445 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4445   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files         347      347           
  Lines       18516    18516           
  Branches     1078     1078           
=======================================
  Hits        17483    17483           
+ Misses        923      920    -3     
- Partials      110      113    +3
Impacted Files Coverage Δ
h/app.py 0% <ø> (ø) ⬆️
src/memex/search/__init__.py 38.88% <0%> (ø) ⬆️
h/stats.py 83.33% <0%> (ø) ⬆️
h/session.py 91.83% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 732dc4d...81228fe. Read the comment docs.

Copy link
Contributor

@nickstenning nickstenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding a comment 🍰

@nickstenning nickstenning merged commit 820a527 into master Mar 22, 2017
@nickstenning nickstenning deleted the csp-allow-inline-styles branch March 22, 2017 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants