-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline stylesheet in adder Shadow DOM conflicts with strict CSP policies #293
Comments
robertknight
added a commit
to hypothesis/h
that referenced
this issue
Mar 21, 2017
Blocking inline styles prevents the client's adder toolbar from working properly on /docs/help and other pages on the site until hypothesis/client#293 is resolved.
nickstenning
pushed a commit
to hypothesis/h
that referenced
this issue
Mar 22, 2017
Blocking inline styles prevents the client's adder toolbar from working properly on /docs/help and other pages on the site until hypothesis/client#293 is resolved.
Some notes on a few things I've learned while experimenting with different options for this:
|
Fixed in 1d2eaf6 by switching to external stylesheets for shadow DOM roots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In browsers that support Shadow DOM, the client uses an inline stylesheet to apply styling to the adder because
<link>
elements are not officially supported in shadow roots (see WICG/webcomponents#530 for lengthy discussion).This will conflict with sites that employ a strict CSP policy that disallows inline styles.
We have a few options:
The text was updated successfully, but these errors were encountered: