Update ht sentry #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where we recommend adding TLS terminating Nginx into the docker-compose file. This is no longer recommended as we already have an nginx instance there for routing purposes. Fixes getsentry#653.
The code assumed GNU getopt, which is not the default on many platforms, notably OSX. Fixes getsentry#656, and replaces getsentry#659.
Closes getsentry#616, supersedes getsentry#651 Adds an option to reduce max memory usage of Clickhouse server. Sets it to 30% of all available RAM as the default. Co-authored-by: Renaud Chaput <[email protected]>
This is for the onpremise release on Sept 15th. The new migration system has a migration to handle recreating the transaction table if the old one is present, we no longer need to do this in `install.sh`.
GitHub team pointed us to docker/compose#3586 as the likely root cause and some digging around revealed got us to https://git.io/JUn7p as a potential fix, which we are trying here.
Closes getsentry#279, supercedes getsentry#306. This is much simpler and safer now that we have `nginx` in front of everything. Thanks a lot @larsnystrom!
Fixes getsentry#502 and applies the suggestions from there: - Number of partitons=1 (from 40) - Log retention to 1 day (from 7 days) These settings should be more suited towards the scale this repo is intended for. NOTE: The partition count change will only affect new installs unless `sentry-kafka` and related volumes are cleaned.
Fixes getsentry#672 I split this PR up into 4 commits. The first one is the bare minimum for the issue. The rest are just consistency corrections that we neckbeards at irc://chat.freenode.net/%23bash would always make.
We need `docker-compose ps -a` for CI so we were already using 1.24.1, this aligns the rest with that. For Docker, there are a bunch of network-related fixes in 19.03.12 and prior (DNS fallback and IPv6 advertising) that we'd like to have to see if they are going to fix some reported connectivity issues w/ onpremise.
@xbenjii reported the following error on getsentry#629: >You requested maxclients of 10000 requiring at least 10032 max file descriptors. Increasing this limit by default makes sense to make Redis more available to heaveier loads.
Probably this is not needed anymore after getsentry/sentry#20984 is merged, but just in case
Our relay connection wasn't behaving correctly because of some missing config in our `sentry.conf.py`. Also, we didn't have the performance module enabled because of a missing feature flag. That's why an entry in the documentation regarding this would be nice.
This fixes a serious bug in install.sh where it ignored externaly set env variable values such as `SENTRY_IMAGE` in favor of the ones defined in `.env`, essentially making all our e2e tests usless.
We were relying on the public DSN field coming first from the API and with Python 3, that's not the case to the tests were failing. This PR makes DSN extraction a bit more robust while still avoiding a full-fledged JSON parser.
- Change minimal Docker version to the one in `install.sh` - Add an extra link to the documentation - Change the existing link to point to the correct one.
This is to ensure clean shutdown of Celery, with fully drained queues. This is needed as versions may change the event format and not be backwards compatible. FWIW this is a hacky workaround without a strong guarantee that the queues will be empty. Ideally we'd shutdown everything first, spin up the workers and check for queues being drained every second or so.
Check if docker compose v2, CLI, is available and get semantic version from it, or fallback to get semantic version out of docker-compose v1 when checking minimum requirements during install.sh script Fixes getsentry#962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.