fix(install): Use proper bash testing #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://tldp.org/LDP/abs/html/comparison-ops.html#FTN.AEN3669 The old `[` test has a problem checking for empty strings in combination with logical OR/AND. In this case, it causes the error message: ./install.sh: line 271: [: ==: unary operator expected
If the `:` side of the `||` were ever called, this `if` condition would cause the error: syntax error: operand expected (error token is "== 0")
- Change remaining uses of `[` to `[[` - Don't use quotes around numbers used in arithmetic tests - Use quotes around variables and command substitutions that could be null
BYK
changed the title
BYK
approved these changes
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #672
I split this PR up into 4 commits. The first one is the bare minimum for the issue. The rest are just consistency corrections that we neckbeards at irc://chat.freenode.net/%23bash would always make.