build(plugin-keychain-x): fix tsc compiler errors - missing V1 suffix #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by the bumping of the references in the openapi.json files which had been pointing to older versions of the openapi.json files through git direct links but now we have upgraded to them. Previously the keychain request/response entities were missing the V1 suffix and the cross-references were still using these older versions prior to us making the bumps. [skip ci] Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
referenced
this pull request
in rwat17/cactus
Sep 20, 2023
- add WebsocketProvider options to quorum LP - add test for calling getBlock with verifier Depends on https://github.com/hyperledger/cacti/pull/2709 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Tomasz Awramski <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
|
I'll sneak this change in as part of https://github.com/hyperledger/cacti/pull/2448 to speed things up. |
auto-merge was automatically disabled
September 20, 2023 18:41
Pull request was closed
petermetz
referenced
this pull request
Sep 20, 2023
- add WebsocketProvider options to quorum LP - add test for calling getBlock with verifier Depends on https://github.com/hyperledger/cacti/pull/2709 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Tomasz Awramski <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES
referenced
this pull request
in sandeepnRES/cacti
Dec 21, 2023
- add WebsocketProvider options to quorum LP - add test for calling getBlock with verifier Depends on https://github.com/hyperledger/cacti/pull/2709 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Tomasz Awramski <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by the bumping of the references in the openapi.json
files which had been pointing to older versions of the openapi.json
files through git direct links but now we have upgraded to them.
Previously the keychain request/response entities were missing the
V1 suffix and the cross-references were still using these older versions
prior to us making the bumps.
[skip ci]
Signed-off-by: Peter Somogyvari [email protected]