feat(quorum): add WebsocketProvider options to quorum LP #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rwat17
commented
Jun 12, 2023
rwat17
commented
- add WebsocketProvider options to quorum LP
- add test for calling getBlock with verifier
rwat17
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
rwat17
force-pushed
the
wi-quorum
branch
3 times, most recently
from
eb03da0
to
0bfe6c2
Compare
petermetz
requested changes
Jun 14, 2023
.../cactus-plugin-ledger-connector-quorum/src/main/typescript/plugin-ledger-connector-quorum.ts
Show resolved
Hide resolved
packages/cactus-test-tooling/src/main/typescript/quorum/quorum-test-ledger.ts
Outdated
Show resolved
Hide resolved
rwat17
force-pushed
the
wi-quorum
branch
2 times, most recently
from
604f072
to
bb748f4
Compare
|
@petermetz Yup, did what u asked for :) |
petermetz
requested changes
Aug 29, 2023
There was a problem hiding this comment.
@petermetz Yup, did what u asked for :)
@rwat17 Nice! Thank you for that! Please rebase onto upstream main and resolve the merge conflicts and then pass it back for review!
This was caused by the bumping of the references in the openapi.json files which had been pointing to older versions of the openapi.json files through git direct links but now we have upgraded to them. Previously the keychain request/response entities were missing the V1 suffix and the cross-references were still using these older versions prior to us making the bumps. [skip ci] Signed-off-by: Peter Somogyvari <[email protected]>
- add WebsocketProvider options to quorum LP - add test for calling getBlock with verifier Depends on https://github.com/hyperledger/cacti/pull/2709 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Tomasz Awramski <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
wi-quorum
branch
from
bb748f4
to
d517efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.