Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade dependencies, especially grpc #1507

Closed
petermetz opened this issue Nov 3, 2021 · 2 comments · Fixed by #2563
Closed

build(deps): upgrade dependencies, especially grpc #1507

petermetz opened this issue Nov 3, 2021 · 2 comments · Fixed by #2563
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience P3 Priority 3: Medium Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is.

Comments

@petermetz
Copy link
Contributor

petermetz commented Nov 3, 2021

See the containing epic for more context and the scope of packages that are being affected: #1497


Description

The older edition of grpc increases the configure script's runtime 10 fold due to it requiring native dependencies to be compiled as part of the dependency resolutions.
Recommending to upgrade to @grpc/grpc-js instead to avoid this issue (the latter is written fully in JS/TS)

The old C implementation of gRPC is now officially deprecated and will not receive updates going forward. This makes it a must have for us to upgrade.

image

@petermetz petermetz added ConnectionChain Developer_Experience bug Something isn't working Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. dependencies Pull requests that update a dependency file P5 Priority 5: Lowest labels Nov 3, 2021
@petermetz petermetz self-assigned this Jul 7, 2023
@petermetz petermetz added P3 Priority 3: Medium and removed P5 Priority 5: Lowest labels Jul 7, 2023
@petermetz
Copy link
Contributor Author

$ yarn why grpc
├─ @hyperledger/cacti-weaver-protos-js@workspace:weaver/common/protos-js
│  └─ grpc@npm:1.24.11 (via npm:^1.24.3)
│
├─ @hyperledger/cactus-plugin-ledger-connector-fabric-socketio@workspace:packages/cactus-plugin-ledger-connector-fabric-socketio
│  └─ grpc@npm:1.24.11 (via npm:1.24.11)
│
├─ @hyperledger/cactus-plugin-ledger-connector-iroha@workspace:packages/cactus-plugin-ledger-connector-iroha
│  └─ grpc@npm:1.24.11 (via npm:1.24.11)
│
├─ fabric-ca-client@npm:1.4.19
│  └─ grpc@npm:1.24.11 (via npm:1.24.11)
│
└─ fabric-client@npm:1.4.19
   └─ grpc@npm:1.24.11 (via npm:1.24.11)

@petermetz
Copy link
Contributor Author

A more complete list of native code dependencies that are forcing code compilation of their own (on top of our own code's compilation)

Cactus_CI/build-dev]   ❓  ::group::Link step
| ➤ YN0007: │ @nestjs/core@npm:8.2.0 [4e575] must be built because it never has been before or the last one failed
| ➤ YN0007: │ electron@npm:18.3.7 must be built because it never has been before or the last one failed
| ➤ YN0007: │ grpc-tools@npm:1.11.2 must be built because it never has been before or the last one failed
| ➤ YN0007: │ secp256k1@npm:4.0.2 must be built because it never has been before or the last one failed
| ➤ YN0007: │ keccak@npm:3.0.3 must be built because it never has been before or the last one failed
| ➤ YN0007: │ pkcs11js@npm:1.3.1 must be built because it never has been before or the last one failed
| ➤ YN0007: │ protobufjs@npm:7.2.4 must be built because it never has been before or the last one failed
| ➤ YN0007: │ protobufjs@npm:6.11.3 must be built because it never has been before or the last one failed
| ➤ YN0007: │ secp256k1@npm:4.0.3 must be built because it never has been before or the last one failed
| ➤ YN0007: │ classic-level@npm:1.3.0 must be built because it never has been before or the last one failed
| ➤ YN0007: │ bufferutil@npm:4.0.7 must be built because it never has been before or the last one failed
| ➤ YN0007: │ es5-ext@npm:0.10.62 must be built because it never has been before or the last one failed
| ➤ YN0007: │ utf-8-validate@npm:5.0.10 must be built because it never has been before or the last one failed
| ➤ YN0007: │ esbuild@npm:0.15.5 must be built because it never has been before or the last one failed
| ➤ YN0007: │ nice-napi@npm:1.0.2 must be built because it never has been before or the last one failed
| ➤ YN0007: │ grpc@npm:1.24.11 must be built because it never has been before or the last one failed
| ➤ YN0007: │ web3-bzz@npm:1.8.1 must be built because it never has been before or the last one failed
| ➤ YN0007: │ web3-bzz@npm:1.7.0 must be built because it never has been before or the last one failed
| ➤ YN0007: │ web3-bzz@npm:1.5.2 must be built because it never has been before or the last one failed
| ➤ YN0007: │ cpu-features@npm:0.0.8 must be built because it never has been before or the last one failed
| ➤ YN0007: │ keccak@npm:1.4.0 must be built because it never has been before or the last one failed
| ➤ YN0007: │ secp256k1@npm:3.8.0 must be built because it never has been before or the last one failed
| ➤ YN0007: │ web3-bzz@npm:1.6.0 must be built because it never has been before or the last one failed
| ➤ YN0007: │ deasync@npm:0.1.28 must be built because it never has been before or the last one failed
| ➤ YN0007: │ aws-sdk@npm:2.965.0 must be built because it never has been before or the last one failed
| ➤ YN0007: │ keytar@npm:7.9.0 must be built because it never has been before or the last one failed
| ➤ YN0007: │ cbor@npm:6.0.1 must be built because it never has been before or the last one failed
| ➤ YN0007: │ sqlite3@npm:5.1.5 [aa907] must be built because it never has been before or the last one failed
| ➤ YN0007: │ iso-constants@npm:0.1.2 must be built because it never has been before or the last one failed
| ➤ YN0007: │ web3-bzz@npm:1.7.3 must be built because it never has been before or the last one failed
| ➤ YN0007: │ grpc-tools@npm:1.12.4 must be built because it never has been before or the last one failed
| ➤ YN0007: │ web3-bzz@npm:1.10.0 must be built because it never has been before or the last one failed
| ➤ YN0007: │ keccak@npm:3.0.2 must be built because it never has been before or the last one failed
| ➤ YN0007: │ leveldown@npm:6.1.0 must be built because it never has been before or the last one failed
| ➤ YN0007: │ @trufflesuite/bigint-buffer@npm:1.1.10 must be built because it never has been before or the last one failed
| ➤ YN0007: │ bufferutil@npm:4.0.5 must be built because it never has been before or the last one failed
| ➤ YN0007: │ utf-8-validate@npm:5.0.7 must be built because it never has been before or the last one failed
| ➤ YN0007: │ leveldown@npm:5.6.0 must be built because it never has been before or the last one failed
| ➤ YN0007: │ @apollo/protobufjs@npm:1.2.6 must be built because it never has been before or the last one failed
| ➤ YN0007: │ @apollo/protobufjs@npm:1.2.7 must be built because it never has been before or the last one failed
| ➤ YN0007: │ grpc-tools@npm:1.9.1 must be built because it never has been before or the last one failed
| ➤ YN0007: │ core-js@npm:2.6.12 must be built because it never has been before or the last one failed

petermetz referenced this issue in petermetz/cacti Jul 21, 2023
WORK IN PROGRESS
--------------

1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.18 at the time.
1.2. Also outrighted swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz referenced this issue in petermetz/cacti Jul 22, 2023
WORK IN PROGRESS
--------------

1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.18 at the time.
1.2. Also outrighted swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz referenced this issue in petermetz/cacti Jul 22, 2023
WORK IN PROGRESS
--------------

1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.18 at the time.
1.2. Also outrighted swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES referenced this issue in petermetz/cacti Aug 9, 2023
WORK IN PROGRESS
--------------

1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.18 at the time.
1.2. Also outrighted swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Peter Somogyvari <[email protected]>
Signed-off-by: Sandeep Nishad <[email protected]>
@petermetz petermetz added this to the v2.0.0-alpha.2 milestone Aug 18, 2023
petermetz referenced this issue in petermetz/cacti Sep 10, 2023
WORK IN PROGRESS
--------------

1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.18 at the time.
1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Peter Somogyvari <[email protected]>
Signed-off-by: Sandeep Nishad <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz referenced this issue in petermetz/cacti Sep 11, 2023
WORK IN PROGRESS
--------------

1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.18 at the time.
1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Sandeep Nishad <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz referenced this issue in petermetz/cacti Oct 5, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.18 at the time.
1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Sandeep Nishad <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz referenced this issue in petermetz/cacti Oct 5, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.18 at the time.
1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Sandeep Nishad <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz referenced this issue in petermetz/cacti Oct 12, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.18 at the time.
1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Sandeep Nishad <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz referenced this issue in petermetz/cacti Oct 17, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.19 at the time.
1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Sandeep Nishad <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz referenced this issue Oct 17, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.19 at the time.
1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Sandeep Nishad <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES referenced this issue in sandeepnRES/cacti Dec 21, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase.
1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client
dependencies to the latest stable 2.2.x version which is 2.2.19 at the time.
1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`.
The rest of the diff is due to the incompatibility of the two mentioned.

Fixes https://github.com/hyperledger/cacti/issues/2562
Fixes https://github.com/hyperledger/cacti/issues/1507

Signed-off-by: Sandeep Nishad <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience P3 Priority 3: Medium Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant