-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): fix npm (grpc) build on NodeJS v20.4.0 #2562
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
good-first-issue
Good for newcomers
good-first-issue-400-expert
P2
Priority 2: High
Weaver
Tasks related to the future of Cactus & Weaver together.
Milestone
Comments
petermetz
added
bug
Something isn't working
good-first-issue
Good for newcomers
ConnectionChain
dependencies
Pull requests that update a dependency file
good-first-issue-400-expert
Weaver
Tasks related to the future of Cactus & Weaver together.
labels
Jul 21, 2023
petermetz
referenced
this issue
in petermetz/cacti
Jul 21, 2023
WORK IN PROGRESS -------------- 1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.18 at the time. 1.2. Also outrighted swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
referenced
this issue
in petermetz/cacti
Jul 22, 2023
WORK IN PROGRESS -------------- 1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.18 at the time. 1.2. Also outrighted swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
referenced
this issue
in petermetz/cacti
Jul 22, 2023
WORK IN PROGRESS -------------- 1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.18 at the time. 1.2. Also outrighted swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES
referenced
this issue
in petermetz/cacti
Aug 9, 2023
WORK IN PROGRESS -------------- 1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.18 at the time. 1.2. Also outrighted swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Sandeep Nishad <[email protected]>
petermetz
referenced
this issue
in petermetz/cacti
Sep 10, 2023
WORK IN PROGRESS -------------- 1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.18 at the time. 1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Sandeep Nishad <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
referenced
this issue
in petermetz/cacti
Sep 11, 2023
WORK IN PROGRESS -------------- 1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.18 at the time. 1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Sandeep Nishad <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Sep 11, 2023
Depends on hyperledger-cacti#2562 - build(deps): fix npm (grpc) build on NodeJS v20.4.0 Fixes hyperledger-cacti#2684 Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES
pushed a commit
to petermetz/cacti
that referenced
this issue
Sep 20, 2023
Depends on hyperledger-cacti#2562 - build(deps): fix npm (grpc) build on NodeJS v20.4.0 Fixes hyperledger-cacti#2684 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
referenced
this issue
in petermetz/cacti
Oct 5, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.18 at the time. 1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Sandeep Nishad <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
referenced
this issue
in petermetz/cacti
Oct 5, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.18 at the time. 1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Sandeep Nishad <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
referenced
this issue
in petermetz/cacti
Oct 12, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.18 at the time. 1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Sandeep Nishad <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Oct 16, 2023
Depends on hyperledger-cacti#2562 - build(deps): fix npm (grpc) build on NodeJS v20.4.0 Fixes hyperledger-cacti#2684 [skip ci] Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
referenced
this issue
in petermetz/cacti
Oct 17, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.19 at the time. 1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Sandeep Nishad <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
referenced
this issue
Oct 17, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.19 at the time. 1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Sandeep Nishad <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES
referenced
this issue
in sandeepnRES/cacti
Dec 21, 2023
1. Eliminates all uses of the old `grpc` dependency from the codebase. 1.1. Upgraded all outdated fabirc-network, fabric-client and fabric-ca-client dependencies to the latest stable 2.2.x version which is 2.2.19 at the time. 1.2. Also outright swapped `grpc` declarations with `@grpc/grpc-js`. The rest of the diff is due to the incompatibility of the two mentioned. Fixes https://github.com/hyperledger/cacti/issues/2562 Fixes https://github.com/hyperledger/cacti/issues/1507 Signed-off-by: Sandeep Nishad <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
good-first-issue
Good for newcomers
good-first-issue-400-expert
P2
Priority 2: High
Weaver
Tasks related to the future of Cactus & Weaver together.
Summary
Currently the
configure
script fails if you are trying to execute it onNodeJS v20 because the very outdated grpc dependency that we use in some of the
packages has C++ code that it wants to compile but that is breaking aganist the
new V8 headers that NodeJS v20 ships with.
Related Other Issue
This one is also talking about upgradnig gRPC which is the proposed solution to fix this issue as well:
https://github.com/hyperledger/cacti/issues/1507
Proposed solution
Upgrade the grpc dependencies.
Reproduction
To reproduce:
yarn install
oryarn configure
and then watch it produces errorsLogs
build.log
The text was updated successfully, but these errors were encountered: