Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for user profiles #6568

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Add tests for user profiles #6568

merged 3 commits into from
Feb 14, 2024

Conversation

macfarla
Copy link
Contributor

Add tests to ensure that the profiles are sensible and besu will start with each of them

Refs #6323

@macfarla
test each profile
4e4a00d 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
removed duplicated line
a5bdb1e 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
use non-deprecated name for sync mode
f3bd13f 
Signed-off-by: Sally MacFarlane <[email protected]>
@github-actions GitHub Actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

@macfarla macfarla merged commit 61c7e18 into hyperledger:main Feb 14, 2024
57 checks passed
@macfarla macfarla deleted the profiles-test branch February 14, 2024 05:42
suraneti pushed a commit to suraneti/besu that referenced this pull request Feb 24, 2024
@macfarla @suraneti
Add tests for user profiles (hyperledger#6568)
295e7e4 
* test each profile
* removed duplicated line
* use non-deprecated name for sync mode

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @shemnon