Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of Configuration Profiles #6323

Closed
non-fungible-nelson opened this issue Dec 21, 2023 · 1 comment · Fixed by #6418
Closed

Creation of Configuration Profiles #6323

non-fungible-nelson opened this issue Dec 21, 2023 · 1 comment · Fixed by #6418
Assignees
Labels
enhancement New feature or request mainnet TeamChupa GH issues worked on by Chupacabara Team TeamRevenant GH issues worked on by Revenant Team ux

Comments

@non-fungible-nelson
Copy link
Contributor

non-fungible-nelson commented Dec 21, 2023

Description

As a user, I want a --profile flag that I can set to easily overwrite some defaults. This way, as a new user I can only set one flag and have a good experience out of the box and get familiar with operating Besu more quickly.

Acceptance Criteria

  • New configuration option --profile=string
  • This flag, when set, overrides the defaults in the client with new ones from the parsed profiles.
  • The profiles flag accepts the following profiles (expanded on in other tickets):
  • Any configuration options explicitly set in the config file or command line should overwrite any of the defaults set via the profile (i.e. private network defaults to sync-mode=FAST, if a user sets sync-mode=FULL, then the sync mode should be full
@non-fungible-nelson non-fungible-nelson added enhancement New feature or request TeamRevenant GH issues worked on by Revenant Team mainnet TeamChupa GH issues worked on by Chupacabara Team ux labels Dec 21, 2023
@Gabriel-Trintinalia
Copy link
Contributor

@non-fungible-nelson The initial implementation of this did not consider validation between the flags. I can see that the profiles have some conflicting changes. For example, we cannot have Bonsai and prune-enabled at the same time, or the legacy transaction pool options and sequential transaction pool. The currently implementation of this issue loads all the configuration related to the profile from a toml for simplicity. What would you like to do it here? To keep the conflicting options per profile will introduce a more complex logic to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mainnet TeamChupa GH issues worked on by Chupacabara Team TeamRevenant GH issues worked on by Revenant Team ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants