-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added section about W3C Verifiable Credential/Presentation representation #185
Conversation
@Artemkaaas -- please address the conflicts. Should be easy :-) |
Signed-off-by: artem.ivanov <[email protected]>
Signed-off-by: artem.ivanov <[email protected]>
Signed-off-by: artem.ivanov <[email protected]>
ff5b5bb
to
7cc81af
Compare
Signed-off-by: artem.ivanov <[email protected]>
Signed-off-by: artem.ivanov <[email protected]>
Signed-off-by: artem.ivanov <[email protected]>
Signed-off-by: artem.ivanov <[email protected]>
# Conflicts: # specs.json
Looks good! I think there are some style adjustments to be made -- e.g. when/where to use The only thing that I think is under explained is the use of MessagePack in the spec. I think there should be a sub-section and overview of how MessagePack is used, and at least a link to the MessagePack spec. |
Signed-off-by: artem.ivanov <[email protected]>
Signed-off-by: artem.ivanov <[email protected]>
spec/w3c_representation.md
Outdated
@@ -130,13 +130,6 @@ schema in order to include the information about AnonCreds related definitions t | |||
* `type` - `AnonCredsDefinition` | |||
* `schema` - id of [[ref: Schema]] | |||
* `definition` - id of [[ref: Credential Definition]] | |||
* `revocation_registry` - (Optional) id of [[ref: Revocation Registry Definition]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to remove revocation_registry
as well here? Or was that not supposed to be there, since it is not in the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you look outdated version. revocation_registry
is not there anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s why I commented. This commit removed the encoding everywhere else, but in this one place it also removed the “revocation_registry” line — different from the intent of the commit. I’m sure it is fine, but just wanted to make sure you intended to do that. Sounds like you did.
Add section describing how AnonCreds credentials and presentations can be represented in the W3C Data Model standard.