-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design: AnonCreds Credentials using the W3C Standard #266
Conversation
ccd9c3d
to
60d5079
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks good. I've left some comments and questions, also to get a better understanding of how the result of this work can be integrated into AFJ (and ACA-Py)
60d5079
to
4d70d93
Compare
Signed-off-by: artem.ivanov <[email protected]>
4d70d93
to
3df1bc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very up to date with the intricate details of the w3c vc data model 1.1 and data integrity proof so if I mentioned something that does not make sense, feel free to ignore it.
bf813a5
to
d7e3206
Compare
Signed-off-by: artem.ivanov <[email protected]>
d7e3206
to
6b3d7e2
Compare
A list of open questions (some with proposed answers) in one place (to be extended / updated): link |
Signed-off-by: artem.ivanov <[email protected]>
326ede2
to
21589e7
Compare
Signed-off-by: artem.ivanov <[email protected]>
21589e7
to
580bd34
Compare
Signed-off-by: artem.ivanov <[email protected]>
78386da
to
11795bd
Compare
Signed-off-by: artem.ivanov <[email protected]>
a1c54f5
to
57b8912
Compare
Signed-off-by: artem.ivanov <[email protected]>
I opened PR in anoncreds-spec repository which add W3C section into AnonCreds credentials specification. I'm going to exclude |
Signed-off-by: artem.ivanov <[email protected]>
f61b2dc
to
eba2c42
Compare
Nice documents. Do you have a design [E-R Diagram or anything related to that] explaining how this all adds up? |
Signed-off-by: artem.ivanov <[email protected]>
@vortex-hue what do you mean? The flow itself keeps the same as before (Spec). Now you have a set of parallel methods to get the data in a different format. |
Anyone know why a test is failing here? Re-ran the failed test and got it in Ubuntu GHA (Windows the previous time). We can merge this documentation only PR with this, but didn't want the error to be ignored. |
@swcurran Should I clean the section with questions before merge? |
…on for updating revocation state Signed-off-by: artem.ivanov <[email protected]>
It would be appreciated. Nice to have as well changing the “in the future” items to be now. For example, the for example, the first line that says (more or less) “Currently we don’t support W3C VC Format”. It should say something like “Here is how we support W3C VC Format…”. Not crucial, but this will be long lived docs, so clean up is good. |
Signed-off-by: artem.ivanov <[email protected]>
This PR contains the very first DRAFT working version of the design documents connected to adoption of AnonCreds Verifiable Credentials and Presentations for the W3C Verifiable Credentials Data Model Standard.
The main goal of this PR is starting the discussion on the proposed format and implementation path / API.
Currently, the PR contains two main documents:
spec.md
- document describing how AnonCreds credentials and presentations should be represented in the W3C Data Modelw3c-representation.md
- document describing proposedanoncreds-rs
API changes and implementation path.