-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed credential signature data model #164
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
be92b3a
completed credential signature data model
51596a5
removed todo section
acc161a
fixed typo
3524033
Merge branch 'main' into cred-sign-model
aritroCoder cd79feb
Merge branch 'hyperledger:main' into cred-sign-model
aritroCoder 30b3fe0
added m_2 encoding
328346a
Merge branch 'cred-sign-model' of https://github.com/aritroCoder/anon…
ea35545
Merge branch 'main' into cred-sign-model
swcurran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -445,20 +445,13 @@ community. | |
|
||
The credential signature elements are constructed as follows: | ||
|
||
::: todo | ||
|
||
Add the details about the credential signature data elements | ||
|
||
::: | ||
|
||
* `m_2` is the *TO BE ADDED*. It is constructed as follows: | ||
* *TO BE ADDED* | ||
* `a` is the *TO BE ADDED*. It is constructed as follows: | ||
* *TO BE ADDED* | ||
* `e` is the *TO BE ADDED*. It is constructed as follows: | ||
* *TO BE ADDED* | ||
* `v` is the *TO BE ADDED*. It is constructed as follows: | ||
* *TO BE ADDED* | ||
* `m_2` is a linkable identifier to the holder that is also called the `master_secret` in old versions. It is constructed as follows: | ||
* $m_2 = H(i || \mathcal{H})$, where $i$ is an index assigned to the holder, and $\mathcal{H}$ is an identifier with which the [[ref: holder]] is known to the [[ref: issuer]]. | ||
* `a` is the signature of the blinded known attributes. It's generation is given above. | ||
* `e` is a random prime generated by the [[ref: issuer]] for creating signature. | ||
* `v` is a number generated by the [[ref: holder]] to unblind the signature of the blinded attributes. It is constructed as follows: | ||
* $v = v' + v''$, where $v'$ is the blinding factor which the holder has and $v''$ is the random number generated by the issuer. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "and I think it should be a "is a random number...", as I assume they generate it on the fly? I would think that the attributes (e.g. the size) of the number should be indicated? |
||
|
||
#### The Credential Signature Correctness Proof | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add how is encoded. I believe for anoncreds 1.0 its base 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it is encoded in decimal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this into the spec