Completed credential signature data model #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2023 01:35
Signed-off-by: aritroCoder <[email protected]>
Signed-off-by: aritroCoder <[email protected]>
swcurran
reviewed
Aug 30, 2023
spec/data_flow_issuance.md
Outdated
| * `a` is the signature of the blinded known attributes. It's generation is given above. | ||
| * `e` is a random prime generated by the [[ref: issuer]] for creating signature. | ||
| * `v` is a number generated by the [[ref: holder]] to unblind the signature of the blinded attributes. It is constructed as follows: | ||
| * $v = v' + v''$, where $v'$ is the blinding factor which the holder has and $v''$ is the random number generated by the issuer. |
There was a problem hiding this comment.
"and
I think it should be a "is a random number...", as I assume they generate it on the fly? I would think that the attributes (e.g. the size) of the number should be indicated?
Signed-off-by: aritroCoder <[email protected]>
mikelodder7
approved these changes
Aug 31, 2023
mikelodder7
reviewed
Aug 31, 2023
| * *TO BE ADDED* | ||
| * `m_2` is a linkable identifier to the holder that is also called the `master_secret` in old versions. It is constructed as follows: | ||
| * $m_2 = H(i || \mathcal{H})$, where $i$ is an index assigned to the holder, and $\mathcal{H}$ is an identifier with which the [[ref: holder]] is known to the [[ref: issuer]]. | ||
| * `a` is the signature of the blinded known attributes. It's generation is given above. |
There was a problem hiding this comment.
Add how is encoded. I believe for anoncreds 1.0 its base 10
There was a problem hiding this comment.
yes, it is encoded in decimal
There was a problem hiding this comment.
added this into the spec
Signed-off-by: Aritra Bhaduri <[email protected]>
Signed-off-by: aritroCoder <[email protected]>
…creds-spec into cred-sign-model Signed-off-by: Aritra Bhaduri <[email protected]>
swcurran
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should be merged only after merging #162, otherwise the changes does not make much sense