No id creation

[berendsliedrecht]

closes #4
closes #13
closes #23

It also picks up some tasks from other tickets. Mainly with regards to the "remove to_unqualified...".

Might have to do some clean up (most String can be converted to &str).

There are two major TODOs which I need some help with.

Right now we have some presentation filter, like: schema issuer, schema name, etc. Before we could derive this from the schema id, but not anymore. How will we deal with this? As the schema id has no guarantee of being "qualified" we can not use it.

I believe we can do these from the filters without changing anything:

    Ok(Filter {
        schema_id,         // YES
        schema_name,       // NO
        schema_issuer_did, // NO
        schema_version,    // NO
        cred_def_id,       // YES
        issuer_did,        // NO
    })

We can allow for more data to be passed in which can be gotten from an object resolution on the ledger or whatever.

The second one is the wrappers. I did not update them, but updating them would be trivial as they are just FFI-wrappers without complex logic build atop. I can create an issue for that if there is none.

[TimoGlastra]

Woot, great work @blu3beri!!

[TimoGlastra]

@dkulic this is probably also relevant to you, as it touches some things you were also working I think

[berendsliedrecht]

@TimoGlastra I have added some wrappers around the anoncred identifiers. If we need validation on an Anoncreds object it can easily be added.

[TimoGlastra]

LGTM, but not a rust developer so maybe someone should take a look at it aswell :)

[swcurran]

@andrewwhitehead -- can you take a look, per @TimoGlastra request?

[berendsliedrecht]

Just as a note, I will create a follow up PR doing some cleanup for the codebase.

[TimoGlastra]

@whalelephant feel free to also leave a review if you have time

[dkulic]

Wow, great work. Thanks.
I was busy with some other stuff, will try to get involved more.

[dkulic]

Is there any reason why we do not use CredentialDefinitionId here?

[berendsliedrecht]

Ah I think that one was not changed, I will update this.

[berendsliedrecht]

I used quite a bit of impl Into<SchemaId> but it might be better to do impl TryInto<SchemaId> so we can validate when we call into. This almost automatically adds validation. Can do this in a follow up PR to keep this one smaller.

[dkulic]

LGTM