Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update credential definition methods to not generate id based on credential definition values #13

Closed
3 tasks
TimoGlastra opened this issue Nov 3, 2022 · 0 comments · Fixed by #25
Closed
3 tasks
Assignees

Comments

@TimoGlastra
Copy link
Member

See #4 for general context and possible approaches

As the identifiers can now be any URI, we should update the methods in the AnonCreds library to not generate the id values, but rather allow the user to generate the IDs themselves based on the AnonCreds method they're using.

  • Update the credx_create_credential_definition ffi method based on the chosen approach
    • remove origin_did as parameter
    • based on the chosen approach, add a cred_def_id parameter or not
  • Update the create_credential_definition issuer.rs method based on the choses approach
    • remove origin_did parameter
    • based on the chosen approach, add a cred_def_id parameter or not
    • remove the generation of the cred_def_id based on the credential definition values
    • remove the logic of extracting the seq_no from the schema for the schema_id property in the cred_def, but rather use the schema.id directly for the schema_id property.
  • If the frist approach is taken, we need to update all validation logic and make the cred_def_id optional (but only in some cases). This requires some refactoring probably
@berendsliedrecht berendsliedrecht self-assigned this Dec 7, 2022
@berendsliedrecht berendsliedrecht moved this from Todo to In Progress in Ledger Agnostic AnonCreds Dec 7, 2022
Repository owner moved this from In Progress to Done in Ledger Agnostic AnonCreds Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants