Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added currentAccumulator support #122

Merged
merged 6 commits into from
Mar 9, 2023

Conversation

berendsliedrecht
Copy link
Contributor

@berendsliedrecht berendsliedrecht commented Feb 28, 2023

closes #51

Signed-off-by: blu3beri [email protected]

}

// fn visit_seq<V>(self, mut seq: V) -> Result<UrsaRevocationRegistry, V::Error>
// where
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this he removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I created a PR, but it should be more a draft as not all the tests are working, yet. Once all the tests are working I will remove the unused code.

blu3beri added 3 commits March 7, 2023 13:29
Signed-off-by: blu3beri <[email protected]>
Signed-off-by: blu3beri <[email protected]>
Signed-off-by: blu3beri <[email protected]>
Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing 🙃

@berendsliedrecht
Copy link
Contributor Author

CI is failing 🙃

Yeah it's almost finished :D

Signed-off-by: blu3beri <[email protected]>
@berendsliedrecht berendsliedrecht merged commit b2bee57 into hyperledger:main Mar 9, 2023
@berendsliedrecht berendsliedrecht deleted the serde-accum-key branch March 9, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serde RevocationStatusList field name
2 participants