Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serde RevocationStatusList field name #51

Closed
whalelephant opened this issue Jan 9, 2023 · 0 comments · Fixed by #122
Closed

Serde RevocationStatusList field name #51

whalelephant opened this issue Jan 9, 2023 · 0 comments · Fixed by #122
Assignees
@berendsliedrecht

Comments

@whalelephant
Copy link
Contributor

whalelephant commented Jan 9, 2023 •
edited by TimoGlastra
Loading

The proposed RevocationStatusList field name that contains the current accumulator value is currentAccumulator.

As the accumulator is in the RevocationRegisty struct in libursa, the accum field is private and serde with the same field name.

Current situation is to keep the field name accum but we will need to either update the specs or find a workaround for serde.

Hacky approach, but also create a PR (and think about backwards compatibility).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berendsliedrecht berendsliedrecht

Labels
None yet
Projects
Ledger Agnostic AnonCreds
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added currentAccumulator support berendsliedrecht/anoncreds-rs
2 participants
@whalelephant @berendsliedrecht