-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix object labels #89
Comments
The following seem to work ok... Labels:
Annotations:
I also wonder whether adding a |
jt-nti
added a commit
to jt-nti/fabric-builder-k8s
that referenced
this issue
May 24, 2024
Base32 encode the package hash and validate the chaincode label in the build phase Move labels that cannot be guaranteed to be valid to annotations instead Closes hyperledger-labs#89 Signed-off-by: James Taylor <[email protected]>
jt-nti
added a commit
to jt-nti/fabric-builder-k8s
that referenced
this issue
May 24, 2024
Base32 encode the package hash and validate the chaincode label in the build phase Move labels that cannot be guaranteed to be valid to annotations instead Closes hyperledger-labs#89 Signed-off-by: James Taylor <[email protected]>
jt-nti
added a commit
to jt-nti/fabric-builder-k8s
that referenced
this issue
May 24, 2024
Base32 encode the package hash and validate the chaincode label in the build phase Move labels that cannot be guaranteed to be valid to annotations instead Closes hyperledger-labs#89 Signed-off-by: James Taylor <[email protected]>
jt-nti
added a commit
to jt-nti/fabric-builder-k8s
that referenced
this issue
May 24, 2024
Base32 encode the package hash and validate the chaincode label in the build phase Move labels that cannot be guaranteed to be valid to annotations instead Closes hyperledger-labs#89 Signed-off-by: James Taylor <[email protected]>
jt-nti
added a commit
that referenced
this issue
May 24, 2024
Base32 encode the package hash and validate the chaincode label in the build phase Move labels that cannot be guaranteed to be valid to annotations instead Closes #89 Signed-off-by: James Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MSP and peer ID annotations look like they might cause problems. Also potentially related to #88, can the object labels be improved to make management easier?
Valid label values:
Possible label changes:
The text was updated successfully, but these errors were encountered: