k8s owner reference is not set in CC child pod

[jkneubuh]

When the chaincode pod is created by the k8s builder, it does not currently set the pod owner attribute.
https://kubernetes.io/docs/concepts/overview/working-with-objects/owners-dependents/

Update the owner reference for the child pod such that it is set as a dependent resource created by the peer. This will force k8s to run an automatic GC of the chaincode pod if/when the peer is terminated.

Some original context and thread was discussed over on discord at #fabric-kubernetes, reported by @alius.miles

[tbondarchuk]

Example of project using standalone pods but with owner set: cnpg

[jt-nti]

I think there are a couple of cases where an owner reference won't be possible:

• The peer, and therefore the k8s builder, doesn't always run in kubernetes
• If the FABRIC_K8S_BUILDER_NAMESPACE environment variable is set the chaincode pod could be in a different namespace to the peer:
  "A valid owner reference consists of the object name and a UID within the same namespace as the dependent object."

[Vikash-8090-Yadav]

Hey, @jt-nti @jkneubuh I want to work on this. Can u please provide more information on what exactly the problem is?

[jt-nti]

Hi @Vikash-8090-Yadav, the background to this issue is in a Discord thread which is linked above, along with the Kubernetes doc on owners and dependents. This issue is to add the required configuration to the chaincode pod when possible, e.g. see the link Taras put in his comment. The builder would need to be running in Kubernetes, and in the same namespace, which I think it should be possible to check.

[solo-daemon]

Hi, I would like to work on this issue

[solo-daemon]

@jt-nti @jkneubuh I have added a pr which checks if a peer pod exist in the same namespace in which we are creating the chain pod it will set the peer pod as an owner. Is this the right approach ?

[jt-nti]

Hopefully this issue won't be necessary after switching to kubernetes jobs. See #119

[jt-nti]

With #119, kubernetes now cleans up chaincode jobs/pods when the peer is terminated