Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Remove permission tokens from role on unregistration #4242

Closed
Erigara opened this issue Jan 30, 2024 · 2 comments
Closed

[BUG]: Remove permission tokens from role on unregistration #4242

Erigara opened this issue Jan 30, 2024 · 2 comments
Assignees
@Erigara
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix

Comments

@Erigara
Copy link
Contributor

Erigara commented Jan 30, 2024

Continuation of #3962.

I've just noticed that as well as removing token from account we should also remove tokens from roles.

Problem is that roles aren't mutable right now.
@Erigara Erigara added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Jan 30, 2024
@mversic
Copy link
Contributor

mversic commented Jan 30, 2024

  1. we can unregister and register a role
  2. we can make an internal update role isi

@Erigara
Copy link
Contributor Author

Erigara commented Jan 30, 2024

  1. we can unregister and register a role

currently role is removed on unregistration from every account so we have to do a lot of bookkeeping to do that

  1. we can make an internal update role isi

and only allow execution from executor? maybe consider updating roles?

@Erigara Erigara self-assigned this Apr 1, 2024
Erigara added a commit to Erigara/iroha that referenced this issue Apr 3, 2024
@Erigara
[fix] hyperledger-iroha#4242: Remove permissions from roles on entity…
139fe3b 
… unregistration

Signed-off-by: Shanin Roman <[email protected]>
@Erigara Erigara mentioned this issue Apr 3, 2024
Merged
Erigara added a commit to Erigara/iroha that referenced this issue Apr 3, 2024
@Erigara
[fix] hyperledger-iroha#4242: Remove permissions from roles on entity…
9dc0124 
… unregistration

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Apr 3, 2024
@Erigara
[fix] hyperledger-iroha#4242: Remove permissions from roles on entity…
264ae20 
… unregistration

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Apr 9, 2024
@Erigara
[fix] hyperledger-iroha#4242: Remove permissions from roles on entity…
136b1da 
… unregistration

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit that referenced this issue Apr 11, 2024
@Erigara
[fix] #4242: Remove permissions from roles on entity unregistration
4eb83ff 
Signed-off-by: Shanin Roman <[email protected]>
@timofeevmd timofeevmd added the QA-confirmed This bug is reproduced and needs a fix label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Erigara @mversic @timofeevmd