Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Permission tokens aren't removed #3962

Closed
Erigara opened this issue Oct 5, 2023 · 3 comments
Closed

[BUG]: Permission tokens aren't removed #3962

Erigara opened this issue Oct 5, 2023 · 3 comments
Assignees
@Erigara @timofeevmd
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix Security This issue asks for improved security

Comments

@Erigara
Copy link
Contributor

Erigara commented Oct 5, 2023

Currently permission tokens aren't removed when there associated entity is removed.

This makes scenarios like this one possible:

  1. Account A register asset definition and give account B token to unregister it
  2. Account A unregister asset definition
  3. Account C register asset definition with the same id
  4. Account B can unregister this asset definition
@Erigara Erigara added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Oct 5, 2023
@mversic
Copy link
Contributor

mversic commented Oct 5, 2023

we have the same problem with permissions for domains, accounts, asset definitions and assets. Just about any entity. This sounds like an issue that should be resolved from within executor, not the host

@mversic
Copy link
Contributor

mversic commented Dec 7, 2023

consider introducing a unique integer for every entity (AssetDefinition)

@Erigara
Copy link
Contributor Author

Erigara commented Dec 7, 2023

another option is to prohibit reregistering entities with the same name

@mversic mversic added the Security This issue asks for improved security label Dec 7, 2023
@Erigara Erigara self-assigned this Jan 15, 2024
Erigara added a commit to Erigara/iroha that referenced this issue Jan 18, 2024
@Erigara
[fix] hyperledger-iroha#3962: Add test to check if associated token i…
de6f12d 
…s removed

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Jan 18, 2024
@Erigara
[fix] hyperledger-iroha#3962: Revoke associated tokens on entity unre…
0aade41 
…gistretration

Signed-off-by: Shanin Roman <[email protected]>
@Erigara Erigara mentioned this issue Jan 18, 2024
Merged
Erigara added a commit to Erigara/iroha that referenced this issue Jan 18, 2024
@Erigara
[fix] hyperledger-iroha#3962: Add test to check if associated token i…
eb0819a 
…s removed

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Jan 18, 2024
@Erigara
[fix] hyperledger-iroha#3962: Revoke associated tokens on entity unre…
ebd8988 
…gistretration

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Jan 18, 2024
@Erigara
[fix] hyperledger-iroha#3962: Revoke associated tokens on entity unre…
d75538b 
…gistretration

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Jan 18, 2024
@Erigara
[fix] hyperledger-iroha#3962: Revoke associated tokens on entity unre…
008c3a5 
…gistretration

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Jan 19, 2024
@Erigara
[fix] hyperledger-iroha#3962: Add test to check if associated token i…
8ec5a17 
…s removed

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Jan 19, 2024
@Erigara
[fix] hyperledger-iroha#3962: Revoke associated tokens on entity unre…
b9e64de 
…gistretration

Signed-off-by: Shanin Roman <[email protected]>
mversic pushed a commit to Erigara/iroha that referenced this issue Jan 23, 2024
@Erigara @mversic
[fix] hyperledger-iroha#3962: Add test to check if associated token i…
5c32ab9 
…s removed

Signed-off-by: Shanin Roman <[email protected]>
mversic pushed a commit to Erigara/iroha that referenced this issue Jan 23, 2024
@Erigara @mversic
[fix] hyperledger-iroha#3962: Revoke associated tokens on entity unre…
03dcd67 
…gistretration

Signed-off-by: Shanin Roman <[email protected]>
mversic pushed a commit to Erigara/iroha that referenced this issue Jan 24, 2024
@Erigara @mversic
[fix] hyperledger-iroha#3962: Add test to check if associated token i…
8ca5ec4 
…s removed

Signed-off-by: Shanin Roman <[email protected]>
mversic pushed a commit to Erigara/iroha that referenced this issue Jan 24, 2024
@Erigara @mversic
[fix] hyperledger-iroha#3962: Revoke associated tokens on entity unre…
3e9f3f8 
…gistretration

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Jan 25, 2024
@Erigara
[fix] hyperledger-iroha#3962: Add test to check if associated token i…
c5ee988 
…s removed

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Jan 25, 2024
@Erigara
[fix] hyperledger-iroha#3962: Revoke associated tokens on entity unre…
669ea1a 
…gistretration

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit that referenced this issue Jan 25, 2024
@Erigara
[fix] #3962: Add test to check if associated token is removed
8575dae 
Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit that referenced this issue Jan 25, 2024
@Erigara
[fix] #3962: Revoke associated tokens on entity unregistretration
ed6eb3e 
Signed-off-by: Shanin Roman <[email protected]>
@timofeevmd timofeevmd self-assigned this Jan 25, 2024
@timofeevmd timofeevmd added the QA-confirmed This bug is reproduced and needs a fix label Jan 25, 2024
@Erigara Erigara mentioned this issue Jan 30, 2024
Closed
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this issue Feb 11, 2024
@Erigara @Asem-Abdelhady
[fix] hyperledger-iroha#3962: Add test to check if associated token i…
65ebbaa 
…s removed

Signed-off-by: Shanin Roman <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this issue Feb 29, 2024
@Erigara @mversic
[fix] hyperledger-iroha#3962: Revoke associated tokens on entity unre…
d467b0d 
…gistretration

Signed-off-by: Shanin Roman <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this issue Feb 29, 2024
@Erigara @mversic
[fix] hyperledger-iroha#3962: Revoke associated tokens on entity unre…
19564f0 
…gistretration

Signed-off-by: Shanin Roman <[email protected]>
mversic added a commit that referenced this issue Mar 1, 2024
@mversic
[BACKPORT] #3962: Revoke associated tokens on entity unregistration (#…
2ffcd00 
…4334)

* [refactor] #3640: place permission tokens in a separate module (#3940)

Signed-off-by: Marin Veršić <[email protected]>

* [fix] #3962: Revoke associated tokens on entity unregistretration

Signed-off-by: Shanin Roman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

@timofeevmd timofeevmd

Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix Security This issue asks for improved security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Erigara @mversic @timofeevmd