-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ledger-browser): rename ledger browser #3170
Conversation
rwat17
commented
Apr 3, 2024
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b003fb3
to
f6daec3
Compare
Head branch was pushed to by a user without write access
73866a5
to
7b0cfce
Compare
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
48c13d4
to
67b65dc
Compare
@rwat17 FYI: You can re-try individual jobs on the GitHub UI** instead of doing a dummy force push to force a full re-execution of the entire test suite. The full test suite takes ~3 hours of compute time instead of 5 minutes in this case where it was the ** let me know if you do not have permissions though - we can try to fix that |
@petermetz yeah i know but one time it fails yarn_custom_checkss other time it failed yarn_tools_validate_bundle_names. Thats why im fpushing it heh. One more time and i will try to debug it like u suggested |
@petermetz ok finally it worked but dependent pot pushed before me, so another run is required. Sorry... but my VM is caching something and whole build goes thru on my machine but on github it fails. I need to copy whole project out of the repository, delete main branch, pull it again and then copy whole project back with the changes. Then it works. Pretty annoying. |
@rwat17 Yeah it's pretty difficult/convoluted sometimes and it takes some getting used to, so I totally get it. Direct link to the guide within the PR: https://github.com/hyperledger/cacti/blob/4a9fed35baefeac0ce53fc437820b6c33d2b66f2/FAQ.md#how-do-i-re-run-a-single-job-in-the-ci-through-the-github-ui The PR link: https://github.com/hyperledger/cacti/pull/3187 |
@petermetz I cant re-run CI jobs, the icon is not available. |
@rwat17 Would you have time next week (or today if you are still up for it) to join a screen sharing session where we can debug the permissions? |
@petermetz yeah sure, it would be helpful. You can pick the time in next week, I'm flexible and can hop in even in the evening. Just have in mind that I am 9h ahead of your time :D. |
@rwat17 OK, is the daily pair programming call too late? I'm guessing it is, ,but you tell me! |
@petermetz It is ok. April 8th at 10 AM PDT/PST on discord then :). |
@petermetz I've set DCO to pass, it was failing because commit signoff is indented - hope that's OK :) |
- delete solid.js version - rename package - fix type erros - bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react Closes: hyperledger-cacti#3156 Signed-off-by: Tomasz Awramski <[email protected]>
Head branch was pushed to by a user without write access