Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ledger-browser): rename ledger browser #3170

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

rwat17
Copy link
Contributor

@rwat17 rwat17 commented Apr 3, 2024

refactor(ledger-browser): rename ledger browser
- delete solid.js version
- rename package
- fix type errors
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: #3156

Signed-off-by: Tomasz Awramski <[email protected]>

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwat17 rwat17 force-pushed the browser-rename branch 2 times, most recently from b003fb3 to f6daec3 Compare April 4, 2024 11:36
@outSH outSH enabled auto-merge (rebase) April 4, 2024 11:46
auto-merge was automatically disabled April 4, 2024 14:36

Head branch was pushed to by a user without write access

@petermetz petermetz enabled auto-merge (rebase) April 4, 2024 16:07
auto-merge was automatically disabled April 4, 2024 16:13

Head branch was pushed to by a user without write access

@petermetz petermetz enabled auto-merge (rebase) April 4, 2024 16:44
auto-merge was automatically disabled April 4, 2024 16:50

Head branch was pushed to by a user without write access

@rwat17 rwat17 force-pushed the browser-rename branch 2 times, most recently from 48c13d4 to 67b65dc Compare April 4, 2024 17:05
@petermetz
Copy link
Contributor

@rwat17 FYI: You can re-try individual jobs on the GitHub UI** instead of doing a dummy force push to force a full re-execution of the entire test suite. The full test suite takes ~3 hours of compute time instead of 5 minutes in this case where it was the codegen job that was failing but nothing else. So it's good for the planet to try and be targeted with the retries.

** let me know if you do not have permissions though - we can try to fix that

@rwat17
Copy link
Contributor Author

rwat17 commented Apr 4, 2024

@petermetz yeah i know but one time it fails yarn_custom_checkss other time it failed yarn_tools_validate_bundle_names. Thats why im fpushing it heh. One more time and i will try to debug it like u suggested

@rwat17
Copy link
Contributor Author

rwat17 commented Apr 4, 2024

@petermetz ok finally it worked but dependent pot pushed before me, so another run is required. Sorry... but my VM is caching something and whole build goes thru on my machine but on github it fails. I need to copy whole project out of the repository, delete main branch, pull it again and then copy whole project back with the changes. Then it works. Pretty annoying.
Could you lead me how to run only one workflow to not waste compute time? I can find any option like that and never done sth like excluding workflows. Do I change it inside .github folder or what?

@petermetz
Copy link
Contributor

@petermetz ok finally it worked but dependent pot pushed before me, so another run is required. Sorry... but my VM is caching something and whole build goes thru on my machine but on github it fails. I need to copy whole project out of the repository, delete main branch, pull it again and then copy whole project back with the changes. Then it works. Pretty annoying. Could you lead me how to run only one workflow to not waste compute time? I can find any option like that and never done sth like excluding workflows. Do I change it inside .github folder or what?

@rwat17 Yeah it's pretty difficult/convoluted sometimes and it takes some getting used to, so I totally get it.
I sent a PR just now that adds an entry to the FAQ answering this with screenshots and bullet-points that you can follow along:

Direct link to the guide within the PR: https://github.com/hyperledger/cacti/blob/4a9fed35baefeac0ce53fc437820b6c33d2b66f2/FAQ.md#how-do-i-re-run-a-single-job-in-the-ci-through-the-github-ui

The PR link: https://github.com/hyperledger/cacti/pull/3187

@rwat17
Copy link
Contributor Author

rwat17 commented Apr 5, 2024

@petermetz I cant re-run CI jobs, the icon is not available.

@petermetz
Copy link
Contributor

@petermetz I cant re-run CI jobs, the icon is not available.

@rwat17 Would you have time next week (or today if you are still up for it) to join a screen sharing session where we can debug the permissions?

@rwat17
Copy link
Contributor Author

rwat17 commented Apr 6, 2024

@petermetz I cant re-run CI jobs, the icon is not available.

@rwat17 Would you have time next week (or today if you are still up for it) to join a screen sharing session where we can debug the permissions?

@petermetz yeah sure, it would be helpful. You can pick the time in next week, I'm flexible and can hop in even in the evening. Just have in mind that I am 9h ahead of your time :D.

@petermetz
Copy link
Contributor

@petermetz I cant re-run CI jobs, the icon is not available.

@rwat17 Would you have time next week (or today if you are still up for it) to join a screen sharing session where we can debug the permissions?

@petermetz yeah sure, it would be helpful. You can pick the time in next week, I'm flexible and can hop in even in the evening. Just have in mind that I am 9h ahead of your time :D.

@rwat17 OK, is the daily pair programming call too late? I'm guessing it is, ,but you tell me!
https://wiki.hyperledger.org/display/cactus/Daily+Pair+Programming+Calls

@rwat17
Copy link
Contributor Author

rwat17 commented Apr 7, 2024

@petermetz I cant re-run CI jobs, the icon is not available.

@rwat17 Would you have time next week (or today if you are still up for it) to join a screen sharing session where we can debug the permissions?

@petermetz yeah sure, it would be helpful. You can pick the time in next week, I'm flexible and can hop in even in the evening. Just have in mind that I am 9h ahead of your time :D.

@rwat17 OK, is the daily pair programming call too late? I'm guessing it is, ,but you tell me! https://wiki.hyperledger.org/display/cactus/Daily+Pair+Programming+Calls

@petermetz It is ok. April 8th at 10 AM PDT/PST on discord then :).

@outSH
Copy link
Contributor

outSH commented Apr 8, 2024

@petermetz I've set DCO to pass, it was failing because commit signoff is indented - hope that's OK :)

- delete solid.js version
- rename package
- fix type erros
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <[email protected]>
auto-merge was automatically disabled April 9, 2024 09:07

Head branch was pushed to by a user without write access

@outSH outSH enabled auto-merge (rebase) April 9, 2024 09:08
@outSH outSH merged commit 3cc33b1 into hyperledger-cacti:main Apr 9, 2024
129 of 142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants