Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(faq): add tutorial showing how to re-run a single CI workflow job #3187

Merged

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Apr 4, 2024

  1. This is something that will come in handy as a reference material
    while advising people on how to save on continuous integration
    resources (which are precious)
  2. Refactored the table of contents to be auto-generated by the VSCode
    extension "Markdown All-in-One" so this way we don't have to keep it
    up to date manually.
  3. Also replaced mentions of "Cactus" with "Cacti" in a couple of the
    older FAQ entries.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add this new entry to table of contents at the top of this page.
  • (optionally) I'd also highlight that the refresh button next to search bar can be used as well

@petermetz petermetz force-pushed the docs-faq-re-run-specific-job-only branch from 4a9fed3 to 4239228 Compare May 18, 2024 19:29
@petermetz petermetz requested a review from outSH May 18, 2024 19:29
@petermetz
Copy link
Contributor Author

  • Please add this new entry to table of contents at the top of this page.

    • (optionally) I'd also highlight that the refresh button next to search bar can be used as well

@outSH Thank you for the suggestions, I've applied the changes for both of those points!

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

1. This is something that will come in handy as a reference material
while advising people on how to save on continuous integration
resources (which are precious)
2. Refactored the table of contents to be auto-generated by the VSCode
extension "Markdown All-in-One" so this way we don't have to keep it
up to date manually.
3. Also replaced mentions of "Cactus" with "Cacti" in a couple of the
older FAQ entries.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the docs-faq-re-run-specific-job-only branch from 4239228 to 9b72667 Compare May 23, 2024 00:49
@petermetz petermetz merged commit 3cabe03 into hyperledger-cacti:main May 23, 2024
136 of 144 checks passed
@petermetz petermetz deleted the docs-faq-re-run-specific-job-only branch May 23, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants