-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cactus-plugin-ledger-connector-cdl-socketio): add new connector plugin #2456
feat(cactus-plugin-ledger-connector-cdl-socketio): add new connector plugin #2456
Conversation
@petermetz @izuru0 |
...ges/cactus-plugin-ledger-connector-cdl-socketio/src/main/typescript/connector/cdl-request.ts
Fixed
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH Please see my comments above!
packages/cactus-plugin-ledger-connector-cdl-socketio/Dockerfile
Outdated
Show resolved
Hide resolved
9eab75c
to
8e3cac6
Compare
8e3cac6
to
93d3e03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH LGTM but please check out 2 of my questions in the comments above just to clarify things a bit.
packages/cactus-plugin-ledger-connector-cdl-socketio/tsconfig.json
Outdated
Show resolved
Hide resolved
93d3e03
to
ce1a13e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…plugin - Add new plugin for connecting with Fujitsu CDL. - Add test script for checking connector operations manually. - Peter: Fixed missing dependency declarations - Peter: Consolidated the socket.io versions to the main branch - Peter: Fixed merge conflicts in yarn.lock file Closes: hyperledger-cacti#2455 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Michal Bajer <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
ce1a13e
to
13c7582
Compare
Closes: https://github.com/hyperledger/cacti/issues/2455
Co-authored-by: Peter Somogyvari [email protected]
Signed-off-by: Michal Bajer [email protected]
Signed-off-by: Peter Somogyvari [email protected]