Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cactus-plugin-ledger-connector-cdl-socketio): add new connector plugin #2456

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Jun 14, 2023

  • Add new plugin for connecting with Fujitsu CDL.
  • Add test script for checking connector operations manually.
  • Peter: Fixed missing dependency declarations
  • Peter: Consolidated the socket.io versions to the main branch
  • Peter: Fixed merge conflicts in yarn.lock file

Closes: https://github.com/hyperledger/cacti/issues/2455

Co-authored-by: Peter Somogyvari [email protected]

Signed-off-by: Michal Bajer [email protected]
Signed-off-by: Peter Somogyvari [email protected]

@outSH
Copy link
Contributor Author

outSH commented Jun 14, 2023

@petermetz @izuru0
Please review, more context in issue https://github.com/hyperledger/cacti/issues/2455

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH Please see my comments above!

@outSH outSH force-pushed the cdl_connector_upstream_pr branch 2 times, most recently from 9eab75c to 8e3cac6 Compare June 16, 2023 06:48
@outSH outSH requested a review from petermetz June 16, 2023 06:50
@outSH outSH force-pushed the cdl_connector_upstream_pr branch from 8e3cac6 to 93d3e03 Compare June 26, 2023 08:49
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH LGTM but please check out 2 of my questions in the comments above just to clarify things a bit.

@outSH outSH force-pushed the cdl_connector_upstream_pr branch from 93d3e03 to ce1a13e Compare June 27, 2023 12:52
logger.info(
`Allowing self signed CDL API GW certificates (skipCertCheck=${skipCertCheck})`,
);
agentOptions.rejectUnauthorized = !skipCertCheck;

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…plugin

- Add new plugin for connecting with Fujitsu CDL.
- Add test script for checking connector operations manually.
- Peter: Fixed missing dependency declarations
- Peter: Consolidated the socket.io versions to the main branch
- Peter: Fixed merge conflicts in yarn.lock file

Closes: hyperledger-cacti#2455

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: Michal Bajer <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz merged commit aee28fe into hyperledger-cacti:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(cactus-plugin-ledger-connector-cdl-socketio): add new connector plugin
3 participants