-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support attesting signing key for Hyperlane AVS #3847
Conversation
|
function _updateOperatorSigningKey( | ||
address _operator, | ||
address _newSigningKey | ||
) internal { | ||
address oldSigningKey = address( | ||
uint160(_operatorSigningKeyHistory[_operator].latest()) | ||
); | ||
if (_newSigningKey == oldSigningKey) { | ||
return; | ||
} | ||
_operatorSigningKeyHistory[_operator].push(uint160(_newSigningKey)); | ||
emit SigningKeyUpdate( | ||
_operator, | ||
block.number, | ||
_newSigningKey, | ||
oldSigningKey | ||
); | ||
} |
Check warning
Code scanning / Slither
Unused return Medium
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3847 +/- ##
==========================================
- Coverage 63.47% 62.96% -0.52%
==========================================
Files 125 125
Lines 1555 1574 +19
Branches 170 173 +3
==========================================
+ Hits 987 991 +4
- Misses 542 556 +14
- Partials 26 27 +1
|
Description
Drive-by changes
None
Related issues
None
Backward compatibility
Yes
Testing
Tested by Eigenlayer here: https://github.com/Layr-Labs/eigenlayer-middleware/blob/dev/test/unit/ECDSAStakeRegistryUnit.t.sol