Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support attesting signing key for Hyperlane AVS #3847

Merged
merged 4 commits into from
May 27, 2024

Conversation

aroralanuk
Copy link
Contributor

Description

Drive-by changes

None

Related issues

None

Backward compatibility

Yes

Testing

Tested by Eigenlayer here: https://github.com/Layr-Labs/eigenlayer-middleware/blob/dev/test/unit/ECDSAStakeRegistryUnit.t.sol

Copy link

changeset-bot bot commented May 24, 2024

⚠️ No Changeset found

Latest commit: 9496e83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +383 to +400
function _updateOperatorSigningKey(
address _operator,
address _newSigningKey
) internal {
address oldSigningKey = address(
uint160(_operatorSigningKeyHistory[_operator].latest())
);
if (_newSigningKey == oldSigningKey) {
return;
}
_operatorSigningKeyHistory[_operator].push(uint160(_newSigningKey));
emit SigningKeyUpdate(
_operator,
block.number,
_newSigningKey,
oldSigningKey
);
}

Check warning

Code scanning / Slither

Unused return Medium

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 13.88889% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 62.96%. Comparing base (0cf692e) to head (9496e83).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3847      +/-   ##
==========================================
- Coverage   63.47%   62.96%   -0.52%     
==========================================
  Files         125      125              
  Lines        1555     1574      +19     
  Branches      170      173       +3     
==========================================
+ Hits          987      991       +4     
- Misses        542      556      +14     
- Partials       26       27       +1     
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 67.50% <ø> (ø)
isms 39.52% <ø> (ø)
token 60.83% <ø> (ø)
middlewares 77.05% <ø> (ø)

@aroralanuk aroralanuk enabled auto-merge (squash) May 27, 2024 21:27
@aroralanuk aroralanuk disabled auto-merge May 27, 2024 21:28
@aroralanuk aroralanuk enabled auto-merge (squash) May 27, 2024 21:34
@aroralanuk aroralanuk merged commit d0ce908 into main May 27, 2024
36 of 39 checks passed
@aroralanuk aroralanuk deleted the kunal/stake-registry-key-rotation branch May 27, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants