feat: ecdsa key rotation #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoticWalrus
requested changes
May 20, 2024
There was a problem hiding this comment.
There's one edge case that -- while it doesn't seem likely to be exploited -- could theoretically let a deserving party avoid slashing, by changing keys twice in the same block and signing with the "ephemeral" key, which would never make it into historical storage.
I believe it could be solved by preventing multiple signing key updates within the same block. Implementing this check within the _updateOperatorSigningKey function seems most appropriate to me, personally.
Otherwise the PR LGTM.
|
@ChaoticWalrus addressed the PR comments and added two more unit tests for reference block number checks |
ChaoticWalrus
approved these changes
May 23, 2024
aroralanuk
added a commit
to hyperlane-xyz/hyperlane-monorepo
that referenced
this pull request
May 27, 2024
### Description - Adding support for attesting signing key and key rotation from here Layr-Labs/eigenlayer-middleware#252 ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing Tested by Eigenlayer here: https://github.com/Layr-Labs/eigenlayer-middleware/blob/dev/test/unit/ECDSAStakeRegistryUnit.t.sol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.